diff mbox

improve some error logging in rbd.c

Message ID 20170504201728.25807-1-dab21774@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

David Butterfield May 4, 2017, 8:17 p.m. UTC 
Signed-off-by: David Butterfield <dab21774@gmail.com>
---
 rbd.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Mike Christie May 8, 2017, 5:08 p.m. UTC | #1 
On 05/04/2017 03:17 PM, David Butterfield wrote:
> Signed-off-by: David Butterfield <dab21774@gmail.com>
> ---
>  rbd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/rbd.c b/rbd.c
> index 8f78e54..852338d 100644
> --- a/rbd.c
> +++ b/rbd.c
> @@ -427,18 +427,20 @@ static int tcmu_rbd_open(struct tcmu_device *dev)
>  
>  	pool = strtok(config, "/");
>  	if (!pool) {
> +		tcmu_dev_err(dev, "Could not get pool name\n");
>  		ret = -EINVAL;
>  		goto free_state;
>  	}
>  	state->pool_name = strdup(pool);
>  	if (!state->pool_name) {
>  		ret = -ENOMEM;
> -		tcmu_dev_err(dev, "Could copy pool name\n");
> +		tcmu_dev_err(dev, "Could not copy pool name\n");
>  		goto free_state;
>  	}
>  
>  	name = strtok(NULL, "/");
>  	if (!name) {
> +		tcmu_dev_err(dev, "Could not get image name\n");
>  		ret = -EINVAL;
>  		goto free_state;
>  	}
> @@ -446,7 +448,7 @@ static int tcmu_rbd_open(struct tcmu_device *dev)
>  	state->image_name = strdup(name);
>  	if (!state->image_name) {
>  		ret = -ENOMEM;
> -		tcmu_dev_err(dev, "Could copy image name\n");
> +		tcmu_dev_err(dev, "Could not copy image name\n");
>  		goto free_state;
>  	}
>  

What the heck happend. Merged. Thanks!

--
To unsubscribe from this list: send the line "unsubscribe target-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/rbd.c b/rbd.c
index 8f78e54..852338d 100644
--- a/rbd.c
+++ b/rbd.c
@@ -427,18 +427,20 @@  static int tcmu_rbd_open(struct tcmu_device *dev)
 
 	pool = strtok(config, "/");
 	if (!pool) {
+		tcmu_dev_err(dev, "Could not get pool name\n");
 		ret = -EINVAL;
 		goto free_state;
 	}
 	state->pool_name = strdup(pool);
 	if (!state->pool_name) {
 		ret = -ENOMEM;
-		tcmu_dev_err(dev, "Could copy pool name\n");
+		tcmu_dev_err(dev, "Could not copy pool name\n");
 		goto free_state;
 	}
 
 	name = strtok(NULL, "/");
 	if (!name) {
+		tcmu_dev_err(dev, "Could not get image name\n");
 		ret = -EINVAL;
 		goto free_state;
 	}
@@ -446,7 +448,7 @@  static int tcmu_rbd_open(struct tcmu_device *dev)
 	state->image_name = strdup(name);
 	if (!state->image_name) {
 		ret = -ENOMEM;
-		tcmu_dev_err(dev, "Could copy image name\n");
+		tcmu_dev_err(dev, "Could not copy image name\n");
 		goto free_state;
 	}