| Message ID | 1507974075-6987-1-git-send-email-chris.gekas@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Christos Gkekas <chris.gekas@gmail.com> wrote: > Variable val is unsigned, so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> Patch applied to ath-next branch of ath.git, thanks. d83c0d3293bb ath10k: spectral: remove redundant check in write_file_spectral_count()
diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c index dd9cc09..2048b1e 100644 --- a/drivers/net/wireless/ath/ath10k/spectral.c +++ b/drivers/net/wireless/ath/ath10k/spectral.c @@ -406,7 +406,7 @@ static ssize_t write_file_spectral_count(struct file *file, if (kstrtoul(buf, 0, &val)) return -EINVAL; - if (val < 0 || val > 255) + if (val > 255) return -EINVAL; mutex_lock(&ar->conf_mutex);
Variable val is unsigned, so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@gmail.com> --- drivers/net/wireless/ath/ath10k/spectral.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)