| Message ID | 20181018224546.189268-4-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | qla2xxx patches for kernel v4.20 | expand |
> On Oct 18, 2018, at 3:45 PM, Bart Van Assche <bvanassche@acm.org> wrote: > > External Email > > This patch avoids that the compiler complains about missing declarations > when building with W=1. > > Cc: Himanshu Madhani <himanshu.madhani@cavium.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/qla2xxx/qla_init.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c > index 2ccf9f190c68..6fe20c27acc1 100644 > --- a/drivers/scsi/qla2xxx/qla_init.c > +++ b/drivers/scsi/qla2xxx/qla_init.c > @@ -425,7 +425,7 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea) > __qla24xx_handle_gpdb_event(vha, ea); > } > > -int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport) > +static int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport) > { > struct qla_work_evt *e; > > @@ -1551,7 +1551,8 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, > } > > > -void qla_handle_els_plogi_done(scsi_qla_host_t *vha, struct event_arg *ea) > +static void qla_handle_els_plogi_done(scsi_qla_host_t *vha, > + struct event_arg *ea) > { > ql_dbg(ql_dbg_disc, vha, 0x2118, > "%s %d %8phC post PRLI\n", > -- > 2.19.1.568.g152ad8e336-goog > Looks good. Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com> Thanks, - Himanshu
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c index 2ccf9f190c68..6fe20c27acc1 100644 --- a/drivers/scsi/qla2xxx/qla_init.c +++ b/drivers/scsi/qla2xxx/qla_init.c @@ -425,7 +425,7 @@ void qla24xx_handle_adisc_event(scsi_qla_host_t *vha, struct event_arg *ea) __qla24xx_handle_gpdb_event(vha, ea); } -int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport) +static int qla_post_els_plogi_work(struct scsi_qla_host *vha, fc_port_t *fcport) { struct qla_work_evt *e; @@ -1551,7 +1551,8 @@ void qla24xx_handle_relogin_event(scsi_qla_host_t *vha, } -void qla_handle_els_plogi_done(scsi_qla_host_t *vha, struct event_arg *ea) +static void qla_handle_els_plogi_done(scsi_qla_host_t *vha, + struct event_arg *ea) { ql_dbg(ql_dbg_disc, vha, 0x2118, "%s %d %8phC post PRLI\n",
This patch avoids that the compiler complains about missing declarations when building with W=1. Cc: Himanshu Madhani <himanshu.madhani@cavium.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)