| Message ID | cc7de532fc2398392c2735c085f09d5ee07c3b9b.1543348078.git.dsterba@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Switch defines to enums | expand |
On Tue, Nov 27, 2018 at 08:53:43PM +0100, David Sterba wrote: > We can use simple enum for values that are not part of on-disk format: > block reserve types. Reviewed-by: Omar Sandoval <osandov@fb.com> > Signed-off-by: David Sterba <dsterba@suse.com> > --- > fs/btrfs/ctree.h | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h > index f82ec5e41b0c..40c405d74a01 100644 > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -461,13 +461,18 @@ struct btrfs_space_info { > struct kobject *block_group_kobjs[BTRFS_NR_RAID_TYPES]; > }; > > -#define BTRFS_BLOCK_RSV_GLOBAL 1 > -#define BTRFS_BLOCK_RSV_DELALLOC 2 > -#define BTRFS_BLOCK_RSV_TRANS 3 > -#define BTRFS_BLOCK_RSV_CHUNK 4 > -#define BTRFS_BLOCK_RSV_DELOPS 5 > -#define BTRFS_BLOCK_RSV_EMPTY 6 > -#define BTRFS_BLOCK_RSV_TEMP 7 > +/* > + * Types of block reserves > + */ > +enum { > + BTRFS_BLOCK_RSV_GLOBAL, > + BTRFS_BLOCK_RSV_DELALLOC, > + BTRFS_BLOCK_RSV_TRANS, > + BTRFS_BLOCK_RSV_CHUNK, > + BTRFS_BLOCK_RSV_DELOPS, > + BTRFS_BLOCK_RSV_EMPTY, > + BTRFS_BLOCK_RSV_TEMP, > +}; > > struct btrfs_block_rsv { > u64 size; > -- > 2.19.1 >
On 2018/11/28 上午3:53, David Sterba wrote: > We can use simple enum for values that are not part of on-disk format: > block reserve types. > > Signed-off-by: David Sterba <dsterba@suse.com> Reviewed-by: Qu Wenruo <wqu@suse.com> However more comment will always be a good thing. Thanks, Qu > --- > fs/btrfs/ctree.h | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h > index f82ec5e41b0c..40c405d74a01 100644 > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -461,13 +461,18 @@ struct btrfs_space_info { > struct kobject *block_group_kobjs[BTRFS_NR_RAID_TYPES]; > }; > > -#define BTRFS_BLOCK_RSV_GLOBAL 1 > -#define BTRFS_BLOCK_RSV_DELALLOC 2 > -#define BTRFS_BLOCK_RSV_TRANS 3 > -#define BTRFS_BLOCK_RSV_CHUNK 4 > -#define BTRFS_BLOCK_RSV_DELOPS 5 > -#define BTRFS_BLOCK_RSV_EMPTY 6 > -#define BTRFS_BLOCK_RSV_TEMP 7 > +/* > + * Types of block reserves > + */ > +enum { > + BTRFS_BLOCK_RSV_GLOBAL, > + BTRFS_BLOCK_RSV_DELALLOC, > + BTRFS_BLOCK_RSV_TRANS, > + BTRFS_BLOCK_RSV_CHUNK, > + BTRFS_BLOCK_RSV_DELOPS, > + BTRFS_BLOCK_RSV_EMPTY, > + BTRFS_BLOCK_RSV_TEMP, > +}; > > struct btrfs_block_rsv { > u64 size; >
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h index f82ec5e41b0c..40c405d74a01 100644 --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -461,13 +461,18 @@ struct btrfs_space_info { struct kobject *block_group_kobjs[BTRFS_NR_RAID_TYPES]; }; -#define BTRFS_BLOCK_RSV_GLOBAL 1 -#define BTRFS_BLOCK_RSV_DELALLOC 2 -#define BTRFS_BLOCK_RSV_TRANS 3 -#define BTRFS_BLOCK_RSV_CHUNK 4 -#define BTRFS_BLOCK_RSV_DELOPS 5 -#define BTRFS_BLOCK_RSV_EMPTY 6 -#define BTRFS_BLOCK_RSV_TEMP 7 +/* + * Types of block reserves + */ +enum { + BTRFS_BLOCK_RSV_GLOBAL, + BTRFS_BLOCK_RSV_DELALLOC, + BTRFS_BLOCK_RSV_TRANS, + BTRFS_BLOCK_RSV_CHUNK, + BTRFS_BLOCK_RSV_DELOPS, + BTRFS_BLOCK_RSV_EMPTY, + BTRFS_BLOCK_RSV_TEMP, +}; struct btrfs_block_rsv { u64 size;
We can use simple enum for values that are not part of on-disk format: block reserve types. Signed-off-by: David Sterba <dsterba@suse.com> --- fs/btrfs/ctree.h | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-)