Message ID | 20181207115343.6747-1-kwolf@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | vmdk: Implement blockdev-create | expand |
Patchew URL: https://patchew.org/QEMU/20181207115343.6747-1-kwolf@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20181207115343.6747-1-kwolf@redhat.com Subject: [Qemu-devel] [PATCH v4 0/5] vmdk: Implement blockdev-create Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 914b679 vmdk: Reject excess extents in blockdev-create 2721cff iotests: Add VMDK tests for blockdev-create c098e37 iotests: Filter cid numbers in VMDK extent info 3e8f068 vmdk: Implement .bdrv_co_create callback 54b29ff vmdk: Refactor vmdk_create_extent === OUTPUT BEGIN === Checking PATCH 1/5: vmdk: Refactor vmdk_create_extent... WARNING: line over 80 characters #125: FILE: block/vmdk.c:2114: + flat, compress, zeroed_grain, NULL, opts, errp)) { total: 0 errors, 1 warnings, 104 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/5: vmdk: Implement .bdrv_co_create callback... WARNING: line over 80 characters #216: FILE: block/vmdk.c:2075: + bdrv_get_full_backing_filename_from_filename(blk_bs(blk)->filename, backing_file, WARNING: line over 80 characters #371: FILE: block/vmdk.c:2174: + bool flat, bool split, bool compress, WARNING: line over 80 characters #389: FILE: block/vmdk.c:2192: + rel_filename = g_strdup_printf("%s-flat%s", data->prefix, data->postfix); WARNING: line over 80 characters #406: FILE: block/vmdk.c:2209: +static int coroutine_fn vmdk_co_create_opts(const char *filename, QemuOpts *opts, total: 0 errors, 4 warnings, 658 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/5: iotests: Filter cid numbers in VMDK extent info... Checking PATCH 4/5: iotests: Add VMDK tests for blockdev-create... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #11: new file mode 100755 ERROR: trailing whitespace #282: FILE: tests/qemu-iotests/237.out:28: + format: $ ERROR: trailing whitespace #309: FILE: tests/qemu-iotests/237.out:55: + format: $ ERROR: trailing whitespace #336: FILE: tests/qemu-iotests/237.out:82: + format: $ total: 3 errors, 1 warnings, 584 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 5/5: vmdk: Reject excess extents in blockdev-create... === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20181207115343.6747-1-kwolf@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com