diff mbox series

[2/3] dt-bindings: drm/panel: simple: add Evervision VGG804821

Message ID 20190103182658.16377-3-m.felsch@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series drm/panel: simple: Add support for Evervision VGG804821 | expand

Commit Message

Marco Felsch Jan. 3, 2019, 6:26 p.m. UTC
Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
panel to DRM simple panel driver.

Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt

Comments

Sam Ravnborg Jan. 4, 2019, 4:38 p.m. UTC | #1
Hi Marco.

On Thu, Jan 03, 2019 at 07:26:57PM +0100, Marco Felsch wrote:
> Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
> panel to DRM simple panel driver.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> new file mode 100644
> index 000000000000..82d22e191ac3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> @@ -0,0 +1,12 @@
> +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> +
> +Required properties:
> +- compatible: should be "evervision,vgg804821"
> +- power-supply: See simple-panel.txt
> +
> +Optional properties:
> +- backlight: See simple-panel.txt
> +- enable-gpios: See simple-panel.txt
> +
> +This binding is compatible with the simple-panel binding, which is specified
> +in simple-panel.txt in this directory.

Other bindings just have the compatible listed and the above two lines and
do not repeat the required/optional properties.
If there is not special reason to add these they I suggest to simplify the binding.

	Sam
Rob Herring Jan. 11, 2019, 5:01 p.m. UTC | #2
On Fri, Jan 04, 2019 at 05:38:31PM +0100, Sam Ravnborg wrote:
> Hi Marco.
> 
> On Thu, Jan 03, 2019 at 07:26:57PM +0100, Marco Felsch wrote:
> > Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
> > panel to DRM simple panel driver.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> > ---
> >  .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > new file mode 100644
> > index 000000000000..82d22e191ac3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > @@ -0,0 +1,12 @@
> > +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> > +
> > +Required properties:
> > +- compatible: should be "evervision,vgg804821"
> > +- power-supply: See simple-panel.txt
> > +
> > +Optional properties:
> > +- backlight: See simple-panel.txt
> > +- enable-gpios: See simple-panel.txt
> > +
> > +This binding is compatible with the simple-panel binding, which is specified
> > +in simple-panel.txt in this directory.
> 
> Other bindings just have the compatible listed and the above two lines and
> do not repeat the required/optional properties.
> If there is not special reason to add these they I suggest to simplify the binding.

It is not sufficient to just refer to simple-panel.txt. For example, 
that doesn't convey if a panel has a single supply or multiple and the 
author just ignored supplies. Or what if a panel doesn't have a 
backlight or enable line?

Rob
Rob Herring Jan. 11, 2019, 5:01 p.m. UTC | #3
On Thu,  3 Jan 2019 19:26:57 +0100, Marco Felsch wrote:
> Add support for the Evervision VG804821 800x480 5.0" LCD TFT parallel
> panel to DRM simple panel driver.
> 
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  .../bindings/display/panel/evervision,vgg804821.txt  | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Sam Ravnborg Jan. 11, 2019, 5:17 p.m. UTC | #4
Hi Rob.

> > > +++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
> > > @@ -0,0 +1,12 @@
> > > +Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
> > > +
> > > +Required properties:
> > > +- compatible: should be "evervision,vgg804821"
> > > +- power-supply: See simple-panel.txt
> > > +
> > > +Optional properties:
> > > +- backlight: See simple-panel.txt
> > > +- enable-gpios: See simple-panel.txt
> > > +
> > > +This binding is compatible with the simple-panel binding, which is specified
> > > +in simple-panel.txt in this directory.
> > 
> > Other bindings just have the compatible listed and the above two lines and
> > do not repeat the required/optional properties.
> > If there is not special reason to add these they I suggest to simplify the binding.
> 
> It is not sufficient to just refer to simple-panel.txt. For example, 
> that doesn't convey if a panel has a single supply or multiple and the 
> author just ignored supplies. Or what if a panel doesn't have a 
> backlight or enable line?

Thanks, noted.
I have a few bindings awaiting to be sent that will need a small update.

	Sam
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
new file mode 100644
index 000000000000..82d22e191ac3
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/evervision,vgg804821.txt
@@ -0,0 +1,12 @@ 
+Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
+
+Required properties:
+- compatible: should be "evervision,vgg804821"
+- power-supply: See simple-panel.txt
+
+Optional properties:
+- backlight: See simple-panel.txt
+- enable-gpios: See simple-panel.txt
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.