| Message ID | 20190316200818.8265-14-philmd@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/Kconfig: Fixes when running ./configure --without-default-devices | expand |
> This fixes when configuring with --without-default-devices: > > $ qemu-system-hppa > qemu-system-hppa: Unsupported NIC model: e1000 This is intended. --without-default-devices does not guarantee that you can start the board except with --nodefaults. Paolo
On 3/16/19 10:50 PM, Paolo Bonzini wrote: >> This fixes when configuring with --without-default-devices: >> >> $ qemu-system-hppa >> qemu-system-hppa: Unsupported NIC model: e1000 > > This is intended. --without-default-devices does not guarantee that you can start > the board except with --nodefaults. Ah! Now I get it... Thanks, Phil.
On 16/03/19 23:41, Philippe Mathieu-Daudé wrote: > On 3/16/19 10:50 PM, Paolo Bonzini wrote: >>> This fixes when configuring with --without-default-devices: >>> >>> $ qemu-system-hppa >>> qemu-system-hppa: Unsupported NIC model: e1000 >> >> This is intended. --without-default-devices does not guarantee that you can start >> the board except with --nodefaults. > > Ah! Now I get it... But actually it makes a lot of sense to add these as "imply" directives. This way, disabling CONFIG_PCI_DEVICES does result in a usable system. Paolo
Le lun. 18 mars 2019 10:07, Paolo Bonzini <pbonzini@redhat.com> a écrit : > On 16/03/19 23:41, Philippe Mathieu-Daudé wrote: > > On 3/16/19 10:50 PM, Paolo Bonzini wrote: > >>> This fixes when configuring with --without-default-devices: > >>> > >>> $ qemu-system-hppa > >>> qemu-system-hppa: Unsupported NIC model: e1000 > >> > >> This is intended. --without-default-devices does not guarantee that > you can start > >> the board except with --nodefaults. > > > > Ah! Now I get it... > > But actually it makes a lot of sense to add these as "imply" directives. > This way, disabling CONFIG_PCI_DEVICES does result in a usable system. > Thinking of real hardware, one idea I have is to use a HAS_PCI_SLOTS which "imply PCI_DEVICES". Embedded boards with no slots can't get extra PCI plugged. Similar with other busses. It depends if soldered on-board or if connectors are accessible. Paolo > >
diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig index 2d9b072c21..03d08382cc 100644 --- a/hw/hppa/Kconfig +++ b/hw/hppa/Kconfig @@ -2,6 +2,7 @@ config DINO bool imply PCI_DEVICES select PCI + select E1000_PCI select SERIAL select ISA_BUS select I8259
This fixes when configuring with --without-default-devices: $ qemu-system-hppa qemu-system-hppa: Unsupported NIC model: e1000 Fixes: 9483cf27dd Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com> --- hw/hppa/Kconfig | 1 + 1 file changed, 1 insertion(+)