Message ID | 20190409213102.30124-5-fernando.pacheco@intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | Perma-pin uC firmware and re-enable global reset | expand |
Quoting Fernando Pacheco (2019-04-09 22:31:02)
> This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8.
And don't forget the test code that skips guc.
-Chris
On 4/9/19 2:54 PM, Chris Wilson wrote: > Quoting Fernando Pacheco (2019-04-09 22:31:02) >> This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8. > And don't forget the test code that skips guc. > -Chris Selftests? I couldn't find anything that skips guc. I found some skips for guc submission. Fernando
Quoting Fernando Pacheco (2019-04-16 15:45:03) > > > On 4/9/19 2:54 PM, Chris Wilson wrote: > > Quoting Fernando Pacheco (2019-04-09 22:31:02) > >> This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8. > > And don't forget the test code that skips guc. > > -Chris > > Selftests? I couldn't find anything that skips guc. > I found some skips for guc submission. That should be moved to just skip the per-engine reset. -Chris
On 4/16/19 8:05 AM, Chris Wilson wrote: > Quoting Fernando Pacheco (2019-04-16 15:45:03) >> >> On 4/9/19 2:54 PM, Chris Wilson wrote: >>> Quoting Fernando Pacheco (2019-04-09 22:31:02) >>>> This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8. >>> And don't forget the test code that skips guc. >>> -Chris >> Selftests? I couldn't find anything that skips guc. >> I found some skips for guc submission. > That should be moved to just skip the per-engine reset. > -Chris Thanks for the clarification. Fernando
diff --git a/drivers/gpu/drm/i915/i915_reset.c b/drivers/gpu/drm/i915/i915_reset.c index 68875ba43b8d..6f823d81c428 100644 --- a/drivers/gpu/drm/i915/i915_reset.c +++ b/drivers/gpu/drm/i915/i915_reset.c @@ -625,9 +625,6 @@ int intel_gpu_reset(struct drm_i915_private *i915, bool intel_has_gpu_reset(struct drm_i915_private *i915) { - if (USES_GUC(i915)) - return false; - if (!i915_modparams.reset) return NULL;
This reverts commit fe62365f9f80a1c1d438c54fba21f5108a182de8. Signed-off-by: Fernando Pacheco <fernando.pacheco@intel.com> --- drivers/gpu/drm/i915/i915_reset.c | 3 --- 1 file changed, 3 deletions(-)