| Message ID | 20190707223303.6755-2-digetx@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | More improvements for Tegra30 devfreq driver | expand |
Hi Dmitry, On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote: > IRQ numbers are always positive, hence the corresponding variable should > be unsigned to keep types consistent. This is a minor change that cleans > up code a tad more. > > Suggested-by: Thierry Reding <thierry.reding@gmail.com> > Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > drivers/devfreq/tegra30-devfreq.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c > index a6ba75f4106d..a27300f40b0b 100644 > --- a/drivers/devfreq/tegra30-devfreq.c > +++ b/drivers/devfreq/tegra30-devfreq.c > @@ -160,7 +160,7 @@ struct tegra_devfreq { > > struct tegra_devfreq_device devices[ARRAY_SIZE(actmon_device_configs)]; > > - int irq; > + unsigned int irq; > }; > > struct tegra_actmon_emc_ratio { > @@ -618,12 +618,12 @@ static int tegra_devfreq_probe(struct platform_device *pdev) > return PTR_ERR(tegra->emc_clock); > } > > - tegra->irq = platform_get_irq(pdev, 0); > - if (tegra->irq < 0) { > - err = tegra->irq; > + err = platform_get_irq(pdev, 0); > + if (err < 0) { > dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err); > return err; > } > + tegra->irq = err; > > reset_control_assert(tegra->reset); > > Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index a6ba75f4106d..a27300f40b0b 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -160,7 +160,7 @@ struct tegra_devfreq { struct tegra_devfreq_device devices[ARRAY_SIZE(actmon_device_configs)]; - int irq; + unsigned int irq; }; struct tegra_actmon_emc_ratio { @@ -618,12 +618,12 @@ static int tegra_devfreq_probe(struct platform_device *pdev) return PTR_ERR(tegra->emc_clock); } - tegra->irq = platform_get_irq(pdev, 0); - if (tegra->irq < 0) { - err = tegra->irq; + err = platform_get_irq(pdev, 0); + if (err < 0) { dev_err(&pdev->dev, "Failed to get IRQ: %d\n", err); return err; } + tegra->irq = err; reset_control_assert(tegra->reset);