| Message ID | 20200401203239.163679-5-ebiggers@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | e2fsprogs: fix and document the stable_inodes feature | expand |
On Apr 1, 2020, at 2:32 PM, Eric Biggers <ebiggers@kernel.org> wrote: > > From: Eric Biggers <ebiggers@google.com> > > Signed-off-by: Eric Biggers <ebiggers@google.com> IMHO, it would be better if the updates to the man pages were in the same patch as the patch to misc/tune2fs.c. That said, it's better than *not* getting an update to the man page, so: Reviewed-by: Andreas Dilger <adilger@dilger.ca> > --- > misc/tune2fs.8.in | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/misc/tune2fs.8.in b/misc/tune2fs.8.in > index 3cf1f5ed..582d1da5 100644 > --- a/misc/tune2fs.8.in > +++ b/misc/tune2fs.8.in > @@ -630,6 +630,13 @@ Limit the number of backup superblocks to save space on large filesystems. > .B Tune2fs > currently only supports setting this filesystem feature. > .TP > +.B stable_inodes > +Prevent the filesystem from being shrunk or having its UUID changed, in order to > +allow the use of specialized encryption settings that make use of the inode > +numbers and UUID. > +.B Tune2fs > +currently only supports setting this filesystem feature. > +.TP > .B uninit_bg > Allow the kernel to initialize bitmaps and inode tables lazily, and to > keep a high watermark for the unused inodes in a filesystem, to reduce > -- > 2.26.0.rc2.310.g2932bb562d-goog > Cheers, Andreas
On Wed, Apr 01, 2020 at 08:12:14PM -0600, Andreas Dilger wrote: > On Apr 1, 2020, at 2:32 PM, Eric Biggers <ebiggers@kernel.org> wrote: > > > > From: Eric Biggers <ebiggers@google.com> > > > > Signed-off-by: Eric Biggers <ebiggers@google.com> > > IMHO, it would be better if the updates to the man pages were in the same > patch as the patch to misc/tune2fs.c. > > That said, it's better than *not* getting an update to the man page, so: > > Reviewed-by: Andreas Dilger <adilger@dilger.ca> > Well, I should have included a man page update when adding '-O stable_inodes' originally several months ago. But now it's just being updated, and it makes more sense to have separate patches for fixes and new documentation. - Eric
diff --git a/misc/tune2fs.8.in b/misc/tune2fs.8.in index 3cf1f5ed..582d1da5 100644 --- a/misc/tune2fs.8.in +++ b/misc/tune2fs.8.in @@ -630,6 +630,13 @@ Limit the number of backup superblocks to save space on large filesystems. .B Tune2fs currently only supports setting this filesystem feature. .TP +.B stable_inodes +Prevent the filesystem from being shrunk or having its UUID changed, in order to +allow the use of specialized encryption settings that make use of the inode +numbers and UUID. +.B Tune2fs +currently only supports setting this filesystem feature. +.TP .B uninit_bg Allow the kernel to initialize bitmaps and inode tables lazily, and to keep a high watermark for the unused inodes in a filesystem, to reduce