| Message ID | 20201004162908.3216898-2-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | GPIO support on the Etron EJ168/EJ188/EJ198 xHCI controllers | expand |
On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > Add the vendor ID for Etron Technology, Inc. as well as the device IDs > for the two USB xHCI controllers EJ168 and EJ188. > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> (...) > #define PCI_VENDOR_ID_REDHAT 0x1b36 > > +#define PCI_VENDOR_ID_ETRON 0x1b6f > +#define PCI_DEVICE_ID_ETRON_EJ168 0x7023 > +#define PCI_DEVICE_ID_ETRON_EJ188 0x7052 If you're defining that here, I think it should also be removed in drivers/usb/host/xhci-pci.c by including this file instead? Yours, Linus Walleij
Hi Linus, On Wed, Oct 7, 2020 at 11:14 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl > <martin.blumenstingl@googlemail.com> wrote: > > > Add the vendor ID for Etron Technology, Inc. as well as the device IDs > > for the two USB xHCI controllers EJ168 and EJ188. > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > (...) > > > #define PCI_VENDOR_ID_REDHAT 0x1b36 > > > > +#define PCI_VENDOR_ID_ETRON 0x1b6f > > +#define PCI_DEVICE_ID_ETRON_EJ168 0x7023 > > +#define PCI_DEVICE_ID_ETRON_EJ188 0x7052 > > If you're defining that here, I think it should also be > removed in > drivers/usb/host/xhci-pci.c > by including this file instead? you are absolutely right - I missed that part I will change this in v2 - thanks for pointing it out! Best regards, Martin
On Wed, Oct 07, 2020 at 09:45:23PM +0200, Martin Blumenstingl wrote: > Hi Linus, > > On Wed, Oct 7, 2020 at 11:14 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > > > On Sun, Oct 4, 2020 at 8:00 PM Martin Blumenstingl > > <martin.blumenstingl@googlemail.com> wrote: > > > > > Add the vendor ID for Etron Technology, Inc. as well as the device IDs > > > for the two USB xHCI controllers EJ168 and EJ188. > > > > > > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > > > > (...) > > > > > #define PCI_VENDOR_ID_REDHAT 0x1b36 > > > > > > +#define PCI_VENDOR_ID_ETRON 0x1b6f > > > +#define PCI_DEVICE_ID_ETRON_EJ168 0x7023 > > > +#define PCI_DEVICE_ID_ETRON_EJ188 0x7052 > > > > If you're defining that here, I think it should also be > > removed in > > drivers/usb/host/xhci-pci.c > > by including this file instead? > you are absolutely right - I missed that part > I will change this in v2 - thanks for pointing it out! And please mention the 2+ places these are used in the commit log (see the comment at the top of include/linux/pci_ids.h).
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 1ab1e24bcbce..1c8370aa4b95 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2587,6 +2587,10 @@ #define PCI_VENDOR_ID_REDHAT 0x1b36 +#define PCI_VENDOR_ID_ETRON 0x1b6f +#define PCI_DEVICE_ID_ETRON_EJ168 0x7023 +#define PCI_DEVICE_ID_ETRON_EJ188 0x7052 + #define PCI_VENDOR_ID_AMAZON_ANNAPURNA_LABS 0x1c36 #define PCI_VENDOR_ID_CIRCUITCO 0x1cc8
Add the vendor ID for Etron Technology, Inc. as well as the device IDs for the two USB xHCI controllers EJ168 and EJ188. Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> --- include/linux/pci_ids.h | 4 ++++ 1 file changed, 4 insertions(+)