diff mbox series

[12/29] dt-bindings:iio:dac:ti,dac5571 yaml conversion.

Message ID 20201011170749.243680-13-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series dt-bindings:iio: Another set of yaml conversions. | expand

Commit Message

Jonathan Cameron Oct. 11, 2020, 5:07 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

A few tweaks in this conversion.
* The example didn't have the I2C address of 4C in the node name so
  fixed that.
* The reference voltage in the txt file is an optional binding, but
  the driver is making use of it to provide the scaling of the output
  channels.  As such I have made it required going forwards.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Sean Nyekjaer <sean@geanix.com>
---
 .../bindings/iio/dac/ti,dac5571.txt           | 24 ---------
 .../bindings/iio/dac/ti,dac5571.yaml          | 52 +++++++++++++++++++
 2 files changed, 52 insertions(+), 24 deletions(-)

Comments

Sean Nyekjaer Oct. 11, 2020, 5:47 p.m. UTC | #1 
On 11/10/2020 19.07, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> A few tweaks in this conversion.
> * The example didn't have the I2C address of 4C in the node name so
>    fixed that.
> * The reference voltage in the txt file is an optional binding, but
>    the driver is making use of it to provide the scaling of the output
>    channels.  As such I have made it required going forwards.
>
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Sean Nyekjaer <sean@geanix.com>
>
Looks good :)

/Sean
Jonathan Cameron Oct. 18, 2020, 9:58 a.m. UTC | #2 
On Sun, 11 Oct 2020 19:47:19 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> On 11/10/2020 19.07, Jonathan Cameron wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >
> > A few tweaks in this conversion.
> > * The example didn't have the I2C address of 4C in the node name so
> >    fixed that.
> > * The reference voltage in the txt file is an optional binding, but
> >    the driver is making use of it to provide the scaling of the output
> >    channels.  As such I have made it required going forwards.
> >
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Sean Nyekjaer <sean@geanix.com>
> >  
> Looks good :)

Hi Sean,  Good to know, but if you are happy to give a formal
Acked-by, or Reviewed-by always appreciated!

Thanks,

Jonathan

> 
> /Sean
Sean Nyekjaer Oct. 18, 2020, 3:06 p.m. UTC | #3 
On 18/10/2020 11.58, Jonathan Cameron wrote:
> On Sun, 11 Oct 2020 19:47:19 +0200
> Sean Nyekjaer <sean@geanix.com> wrote:
>
>> On 11/10/2020 19.07, Jonathan Cameron wrote:
>>> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>>
>>> A few tweaks in this conversion.
>>> * The example didn't have the I2C address of 4C in the node name so
>>>     fixed that.
>>> * The reference voltage in the txt file is an optional binding, but
>>>     the driver is making use of it to provide the scaling of the output
>>>     channels.  As such I have made it required going forwards.
>>>
>>> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>>> Cc: Sean Nyekjaer <sean@geanix.com>
>>>   
>> Looks good :)
> Hi Sean,  Good to know, but if you are happy to give a formal
> Acked-by, or Reviewed-by always appreciated!
Acked-by: Sean Nyekjaer <sean@geanix.com>
Sure :)
I just thought it would be weird then I already had the Cc...

/Sean
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.txt b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.txt
deleted file mode 100644
index 03af6b9a4d07..000000000000
--- a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.txt
+++ /dev/null
@@ -1,24 +0,0 @@ 
-* Texas Instruments DAC5571 Family
-
-Required properties:
- - compatible: Should contain
-    "ti,dac5571"
-    "ti,dac6571"
-    "ti,dac7571"
-    "ti,dac5574"
-    "ti,dac6574"
-    "ti,dac7574"
-    "ti,dac5573"
-    "ti,dac6573"
-    "ti,dac7573"
- - reg: Should contain the DAC I2C address
-
-Optional properties:
- - vref-supply: The regulator supply for DAC reference voltage
-
-Example:
-dac@0 {
-	compatible = "ti,dac5571";
-	reg = <0x4C>;
-	vref-supply = <&vdd_supply>;
-};
diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
new file mode 100644
index 000000000000..714191724f7c
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/dac/ti,dac5571.yaml
@@ -0,0 +1,52 @@ 
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/dac/ti,dac5571.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments DAC5571 Family
+
+maintainers:
+  - Sean Nyekjaer <sean@geanix.com>
+
+properties:
+  compatible:
+    enum:
+      - ti,dac5571
+      - ti,dac6571
+      - ti,dac7571
+      - ti,dac5574
+      - ti,dac6574
+      - ti,dac7574
+      - ti,dac5573
+      - ti,dac6573
+      - ti,dac7573
+
+  reg:
+    maxItems: 1
+
+  vref-supply:
+    description:
+      Reference voltage must be supplied to establish the scaling of the
+      output voltage.
+
+required:
+  - compatible
+  - reg
+  - vref-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        dac@4c {
+            compatible = "ti,dac5571";
+            reg = <0x4C>;
+            vref-supply = <&vdd_supply>;
+        };
+    };
+...