| Message ID | 20210119122649.187778-8-nborisov@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Make btrfs W=1 clean | expand |
On Tue, Jan 19, 2021 at 02:26:43PM +0200, Nikolay Borisov wrote: > Fixes fs/btrfs/block-group.c:1570: warning: Function parameter or member 'fs_info' not described in 'btrfs_rmap_block' > > Signed-off-by: Nikolay Borisov <nborisov@suse.com> > --- > fs/btrfs/block-group.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c > index 0886e81e5540..1b71e7be04a9 100644 > --- a/fs/btrfs/block-group.c > +++ b/fs/btrfs/block-group.c > @@ -1554,6 +1554,7 @@ static void set_avail_alloc_bits(struct btrfs_fs_info *fs_info, u64 flags) > > /** > * btrfs_rmap_block - Map a physical disk address to a list of logical addresses > + * @fs_info: fs context I think documenting the fs_info parameter is awkward in all cases, so we could just put 'the filesystem' everywhere. Here 'context' could be confusing as there aready is something called fs_context. > * @chunk_start: logical address of block group > * @physical: physical address to map to logical addresses > * @logical: return array of logical addresses which map to @physical > -- > 2.25.1
diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c index 0886e81e5540..1b71e7be04a9 100644 --- a/fs/btrfs/block-group.c +++ b/fs/btrfs/block-group.c @@ -1554,6 +1554,7 @@ static void set_avail_alloc_bits(struct btrfs_fs_info *fs_info, u64 flags) /** * btrfs_rmap_block - Map a physical disk address to a list of logical addresses + * @fs_info: fs context * @chunk_start: logical address of block group * @physical: physical address to map to logical addresses * @logical: return array of logical addresses which map to @physical
Fixes fs/btrfs/block-group.c:1570: warning: Function parameter or member 'fs_info' not described in 'btrfs_rmap_block' Signed-off-by: Nikolay Borisov <nborisov@suse.com> --- fs/btrfs/block-group.c | 1 + 1 file changed, 1 insertion(+)