diff mbox series

[3/4] gitlab-ci: Build Hexagon cross-toolchain

Message ID 20210228222314.304787-4-f4bug@amsat.org (mailing list archive)
State New, archived
Headers show
Series hexagon: Add Docker image & testing to gitlab-ci | expand

Commit Message

Philippe Mathieu-Daudé Feb. 28, 2021, 10:23 p.m. UTC
Add a job to build the Debian based Hexagon cross-toolchain image.

This image requires a lot of compute time, too much for the common
shared runners. To avoid having the job to timeout, it has to be
built with custom unlimited runner. For this reason we restrict this
job to manual runs.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 .gitlab-ci.d/containers.yml | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Alex Bennée March 4, 2021, 12:08 p.m. UTC | #1
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Add a job to build the Debian based Hexagon cross-toolchain image.
>
> This image requires a lot of compute time, too much for the common
> shared runners. To avoid having the job to timeout, it has to be
> built with custom unlimited runner. For this reason we restrict this
> job to manual runs.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  .gitlab-ci.d/containers.yml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
> index 7137cc4184d..ed57e02e769 100644
> --- a/.gitlab-ci.d/containers.yml
> +++ b/.gitlab-ci.d/containers.yml
> @@ -103,6 +103,16 @@ armhf-debian-cross-container:
>    variables:
>      NAME: debian-armhf-cross
>  
> +hexagon-debian-cross-container:
> +  <<: *container_job_definition
> +  stage: containers-layer2
> +  needs: ['amd64-debian10-container']
> +  when: manual
> +  timeout: 3h
> +  variables:
> +    NAME: debian-hexagon-cross
> +    EXTRA_FILES: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh
> +

We don't really want this - what we need is the ability to run the tests
for hexagon when the registry contains a built container that we have
manually pushed from a build machine:

  https://gitlab.com/qemu-project/qemu/container_registry/1759846

>  hppa-debian-cross-container:
>    <<: *container_job_definition
>    stage: containers-layer2
Paolo Montesel March 4, 2021, 5:43 p.m. UTC | #2
On Thu, Mar 4, 2021 at 1:10 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
>
> > Add a job to build the Debian based Hexagon cross-toolchain image.
> >
> > This image requires a lot of compute time, too much for the common
> > shared runners. To avoid having the job to timeout, it has to be
> > built with custom unlimited runner. For this reason we restrict this
> > job to manual runs.
> >
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > ---
> >  .gitlab-ci.d/containers.yml | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
> > index 7137cc4184d..ed57e02e769 100644
> > --- a/.gitlab-ci.d/containers.yml
> > +++ b/.gitlab-ci.d/containers.yml
> > @@ -103,6 +103,16 @@ armhf-debian-cross-container:
> >    variables:
> >      NAME: debian-armhf-cross
> >
> > +hexagon-debian-cross-container:
> > +  <<: *container_job_definition
> > +  stage: containers-layer2
> > +  needs: ['amd64-debian10-container']
> > +  when: manual
> > +  timeout: 3h
> > +  variables:
> > +    NAME: debian-hexagon-cross
> > +    EXTRA_FILES: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh
> > +
>
> We don't really want this - what we need is the ability to run the tests
> for hexagon when the registry contains a built container that we have
> manually pushed from a build machine:

Ok, so, just to sync, should we submit a minimal patch that only
addresses the docker part of our stuff and then worry about the rest?
That way you can build & upload a container to the registry, and then
we can add a job to .gitlab-ci.yml with the rest of the patchset.

Or, if you plan to mess with the CI yourself, please tell me so we can
avoid spending time on the same thing (should be 5 lines of yaml
anyway).

- Paolo
Alex Bennée March 4, 2021, 6:08 p.m. UTC | #3
Yes, exactly. Already done:

  https://gitlab.com/stsquad/qemu/-/jobs/1073206662

On Thu, 4 Mar 2021 at 17:43, Paolo Montesel <babush@rev.ng> wrote:
>
> On Thu, Mar 4, 2021 at 1:10 PM Alex Bennée <alex.bennee@linaro.org> wrote:
> >
> >
> > Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> >
> > > Add a job to build the Debian based Hexagon cross-toolchain image.
> > >
> > > This image requires a lot of compute time, too much for the common
> > > shared runners. To avoid having the job to timeout, it has to be
> > > built with custom unlimited runner. For this reason we restrict this
> > > job to manual runs.
> > >
> > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > > ---
> > >  .gitlab-ci.d/containers.yml | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > >
> > > diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
> > > index 7137cc4184d..ed57e02e769 100644
> > > --- a/.gitlab-ci.d/containers.yml
> > > +++ b/.gitlab-ci.d/containers.yml
> > > @@ -103,6 +103,16 @@ armhf-debian-cross-container:
> > >    variables:
> > >      NAME: debian-armhf-cross
> > >
> > > +hexagon-debian-cross-container:
> > > +  <<: *container_job_definition
> > > +  stage: containers-layer2
> > > +  needs: ['amd64-debian10-container']
> > > +  when: manual
> > > +  timeout: 3h
> > > +  variables:
> > > +    NAME: debian-hexagon-cross
> > > +    EXTRA_FILES: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh
> > > +
> >
> > We don't really want this - what we need is the ability to run the tests
> > for hexagon when the registry contains a built container that we have
> > manually pushed from a build machine:
>
> Ok, so, just to sync, should we submit a minimal patch that only
> addresses the docker part of our stuff and then worry about the rest?
> That way you can build & upload a container to the registry, and then
> we can add a job to .gitlab-ci.yml with the rest of the patchset.
>
> Or, if you plan to mess with the CI yourself, please tell me so we can
> avoid spending time on the same thing (should be 5 lines of yaml
> anyway).
>
> - Paolo
diff mbox series

Patch

diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
index 7137cc4184d..ed57e02e769 100644
--- a/.gitlab-ci.d/containers.yml
+++ b/.gitlab-ci.d/containers.yml
@@ -103,6 +103,16 @@  armhf-debian-cross-container:
   variables:
     NAME: debian-armhf-cross
 
+hexagon-debian-cross-container:
+  <<: *container_job_definition
+  stage: containers-layer2
+  needs: ['amd64-debian10-container']
+  when: manual
+  timeout: 3h
+  variables:
+    NAME: debian-hexagon-cross
+    EXTRA_FILES: tests/docker/dockerfiles/debian-hexagon-cross.docker.d/build-toolchain.sh
+
 hppa-debian-cross-container:
   <<: *container_job_definition
   stage: containers-layer2