Message ID | ee6d5faebc25c8fa447cf870cbc80b4236178756.camel@coelho.fi (mailing list archive) |
---|---|
State | Changes Requested |
Delegated to: | Kalle Valo |
Headers | show |
Series | pull-request: iwlwifi-next 2021-04-12 | expand |
Luca Coelho <luca@coelho.fi> writes: > Here's the first batch of patches intended for v5.13. This includes > the four last patchsets I sent out for v5.13 with the usual development > work. It also includes Emmanuel's series for adding the iwlmei driver, > including one patch by Alexander Usyskin in the misc drivers directory. > (which Greg asked us to push via our tree). But no Acked-by from Greg? I would like to have that in the commit log. > include/net/cfg80211.h | 11 +- > net/wireless/core.c | 7 +- Why are you changing cfg80211? Has this been checked with Johannes, at least I don't see any acks from him? I prefer making cfg80211 changes via Johannes' tree, smaller risk of conflicts that way. Also every commit seems to have Change-Id tag.
On Mon, 2021-04-12 at 14:43 +0300, Kalle Valo wrote: > > > include/net/cfg80211.h | 11 +- > > net/wireless/core.c | 7 +- > > Why are you changing cfg80211? Has this been checked with Johannes, at > least I don't see any acks from him? I prefer making cfg80211 changes > via Johannes' tree, smaller risk of conflicts that way. Hm. I believe I even have that commit already in my tree. Maybe we talked about it and said you could include it and I forgot? But in any case, it's in my tree now, so probably shouldn't go through iwlwifi as well. johannes
On Mon, 2021-04-12 at 13:49 +0200, Johannes Berg wrote: > On Mon, 2021-04-12 at 14:43 +0300, Kalle Valo wrote: > > > > > include/net/cfg80211.h | 11 +- > > > net/wireless/core.c | 7 +- > > > > Why are you changing cfg80211? Has this been checked with Johannes, at > > least I don't see any acks from him? I prefer making cfg80211 changes > > via Johannes' tree, smaller risk of conflicts that way. > > Hm. I believe I even have that commit already in my tree. Maybe we > talked about it and said you could include it and I forgot? But in any > case, it's in my tree now, so probably shouldn't go through iwlwifi as > well. commit 6f779a66dc84 ("cfg80211: allow specifying a reason for hw_rfkill") johannes
On Mon, 2021-04-12 at 14:43 +0300, Kalle Valo wrote: > Luca Coelho <luca@coelho.fi> writes: > > > Here's the first batch of patches intended for v5.13. This includes > > the four last patchsets I sent out for v5.13 with the usual development > > work. It also includes Emmanuel's series for adding the iwlmei driver, > > including one patch by Alexander Usyskin in the misc drivers directory. > > (which Greg asked us to push via our tree). > > But no Acked-by from Greg? I would like to have that in the commit log. Ugh, sorry, I thought Emmanuel had taken care of this and didn't check. I'll check with him what's the situation with Ack'ing this. > > include/net/cfg80211.h | 11 +- > > net/wireless/core.c | 7 +- > > Why are you changing cfg80211? Has this been checked with Johannes, at > least I don't see any acks from him? I prefer making cfg80211 changes > via Johannes' tree, smaller risk of conflicts that way. Hmmm, this is a patch that I already sent to Johannes too, but I had a mistake in it (some backport stuff slipped through). I guess I'll send him a v2 and then we need to wait with this pull-req until mac80211- next reaches wireless-drivers-next... :( > Also every commit seems to have Change-Id tag. Argh. Sorry about that. Another of my hooks that was not installed on my new machine. -- Luca.
+ Greg Hi Greg, > > Luca Coelho <luca@coelho.fi> writes: > > > Here's the first batch of patches intended for v5.13. This includes > > the four last patchsets I sent out for v5.13 with the usual > > development work. It also includes Emmanuel's series for adding the > > iwlmei driver, including one patch by Alexander Usyskin in the misc drivers > directory. > > (which Greg asked us to push via our tree). > > But no Acked-by from Greg? I would like to have that in the commit log. Not sure if you remember, but Tomas sent a patch to you and then asked to route the patch through the user's tree. So here it is :) Kalle would like to get an ACK from you. This is the latest version of the patch: https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=1b1910e2c82ed5392b90470885d91f3abc1619e2 Thanks!
On Mon, 2021-04-12 at 13:50 +0200, Johannes Berg wrote: > On Mon, 2021-04-12 at 13:49 +0200, Johannes Berg wrote: > > On Mon, 2021-04-12 at 14:43 +0300, Kalle Valo wrote: > > > > > > > include/net/cfg80211.h | 11 +- > > > > net/wireless/core.c | 7 +- > > > > > > Why are you changing cfg80211? Has this been checked with Johannes, at > > > least I don't see any acks from him? I prefer making cfg80211 changes > > > via Johannes' tree, smaller risk of conflicts that way. > > > > Hm. I believe I even have that commit already in my tree. Maybe we > > talked about it and said you could include it and I forgot? But in any > > case, it's in my tree now, so probably shouldn't go through iwlwifi as > > well. > > commit 6f779a66dc84 ("cfg80211: allow specifying a reason for > hw_rfkill") Ah, so you applied it without the backport stuff I left there. Thanks! But this is not in net-next yet, right? So we still need to wait till that reaches net-next and Kalle pulls from there... -- Luca.
On Mon, 2021-04-12 at 14:56 +0300, Luca Coelho wrote: > On Mon, 2021-04-12 at 13:50 +0200, Johannes Berg wrote: > > On Mon, 2021-04-12 at 13:49 +0200, Johannes Berg wrote: > > > On Mon, 2021-04-12 at 14:43 +0300, Kalle Valo wrote: > > > > > > > > > include/net/cfg80211.h | 11 +- > > > > > net/wireless/core.c | 7 +- > > > > > > > > Why are you changing cfg80211? Has this been checked with Johannes, at > > > > least I don't see any acks from him? I prefer making cfg80211 changes > > > > via Johannes' tree, smaller risk of conflicts that way. > > > > > > Hm. I believe I even have that commit already in my tree. Maybe we > > > talked about it and said you could include it and I forgot? But in any > > > case, it's in my tree now, so probably shouldn't go through iwlwifi as > > > well. > > > > commit 6f779a66dc84 ("cfg80211: allow specifying a reason for > > hw_rfkill") > > Ah, so you applied it without the backport stuff I left there. Thanks! > > But this is not in net-next yet, right? So we still need to wait till > that reaches net-next and Kalle pulls from there... Yeah, apparently I got side-tracked after doing mac80211 and forgot mac80211-next ... johannes
On Mon, Apr 12, 2021 at 11:55:23AM +0000, Grumbach, Emmanuel wrote: > + Greg > > Hi Greg, > > > > > Luca Coelho <luca@coelho.fi> writes: > > > > > Here's the first batch of patches intended for v5.13. This includes > > > the four last patchsets I sent out for v5.13 with the usual > > > development work. It also includes Emmanuel's series for adding the > > > iwlmei driver, including one patch by Alexander Usyskin in the misc drivers > > directory. > > > (which Greg asked us to push via our tree). > > > > But no Acked-by from Greg? I would like to have that in the commit log. > > Not sure if you remember, but Tomas sent a patch to you and then asked to route the patch through the user's tree. So here it is :) > Kalle would like to get an ACK from you. This is the latest version of the patch: > > https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.git/commit/?id=1b1910e2c82ed5392b90470885d91f3abc1619e2 I do not remember anything like this, do you have a pointer to the lore.kernel.org thread? Remember I get about 1000 emails a day to do something with (usually ignore...) And I can't review a random commit on a random webpage, that's not how any of this works, you know better. greg k-h
> > On Mon, Apr 12, 2021 at 11:55:23AM +0000, Grumbach, Emmanuel wrote: > > + Greg > > > > Hi Greg, > > > > > > > > Luca Coelho <luca@coelho.fi> writes: > > > > > > > Here's the first batch of patches intended for v5.13. This > > > > includes the four last patchsets I sent out for v5.13 with the > > > > usual development work. It also includes Emmanuel's series for > > > > adding the iwlmei driver, including one patch by Alexander Usyskin > > > > in the misc drivers > > > directory. > > > > (which Greg asked us to push via our tree). > > > > > > But no Acked-by from Greg? I would like to have that in the commit log. > > > > Not sure if you remember, but Tomas sent a patch to you and then asked > > to route the patch through the user's tree. So here it is :) Kalle would like to > get an ACK from you. This is the latest version of the patch: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.g > > it/commit/?id=1b1910e2c82ed5392b90470885d91f3abc1619e2 > > I do not remember anything like this, do you have a pointer to the > lore.kernel.org thread? Remember I get about 1000 emails a day to do > something with (usually ignore...) Bah, I forgot to add this link which I had prepared to paste here: https://lore.kernel.org/lkml/20210206144325.25682-6-tomas.winkler@intel.com/ > > And I can't review a random commit on a random webpage, that's not how > any of this works, you know better. I guess I can resend the patch and CC you to it so that you can review it. > > greg k-h
On Mon, Apr 12, 2021 at 12:19:52PM +0000, Grumbach, Emmanuel wrote: > > > > On Mon, Apr 12, 2021 at 11:55:23AM +0000, Grumbach, Emmanuel wrote: > > > + Greg > > > > > > Hi Greg, > > > > > > > > > > > Luca Coelho <luca@coelho.fi> writes: > > > > > > > > > Here's the first batch of patches intended for v5.13. This > > > > > includes the four last patchsets I sent out for v5.13 with the > > > > > usual development work. It also includes Emmanuel's series for > > > > > adding the iwlmei driver, including one patch by Alexander Usyskin > > > > > in the misc drivers > > > > directory. > > > > > (which Greg asked us to push via our tree). > > > > > > > > But no Acked-by from Greg? I would like to have that in the commit log. > > > > > > Not sure if you remember, but Tomas sent a patch to you and then asked > > > to route the patch through the user's tree. So here it is :) Kalle would like to > > get an ACK from you. This is the latest version of the patch: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/iwlwifi-next.g > > > it/commit/?id=1b1910e2c82ed5392b90470885d91f3abc1619e2 > > > > I do not remember anything like this, do you have a pointer to the > > lore.kernel.org thread? Remember I get about 1000 emails a day to do > > something with (usually ignore...) > > Bah, I forgot to add this link which I had prepared to paste here: > https://lore.kernel.org/lkml/20210206144325.25682-6-tomas.winkler@intel.com/ > > > > > And I can't review a random commit on a random webpage, that's not how > > any of this works, you know better. > > I guess I can resend the patch and CC you to it so that you can review it. The whole series is needed to be resent as the single patch doesn't make sense alone. thanks, greg k-h