mbox series

[V2,0/5] Update pcie-tegra194 driver

Message ID 20210606082204.14222-1-omp@nvidia.com (mailing list archive)
Headers show
Series Update pcie-tegra194 driver | expand

Message

Om Prakash Singh June 6, 2021, 8:21 a.m. UTC 
Update pcie-tegra194 driver with bug fixing and cleanup

Changes from V1->V2
  PCI: tegra: Fix handling BME_CHGED event
	- Update variable naming
  PCI: tegra: Fix MSI-X programming
	- No change
  PCI: tegra: Disable interrupts before entering L2
	- Rephrase the commit message
  PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
	- Update return value to -ENOTSUPP.
  PCI: tegra: Cleanup unused code
	- No Change

V1:
http://patchwork.ozlabs.org/project/linux-pci/patch/20210527115246.20509-2-omp@nvidia.com/

Om Prakash Singh (5):
  PCI: tegra: Fix handling BME_CHGED event
  PCI: tegra: Fix MSI-X programming
  PCI: tegra: Disable interrupts before entering L2
  PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
  PCI: tegra: Cleanup unused code

 drivers/pci/controller/dwc/pcie-tegra194.c | 36 +++++++++++++---------
 1 file changed, 22 insertions(+), 14 deletions(-)

Comments

Om Prakash Singh June 21, 2021, 9:32 a.m. UTC | #1 
Hi Lorenzo, Bjorn,
Can you help review this patch series please?

Thanks,
Om


On 6/6/2021 1:51 PM, Om Prakash Singh wrote:
> Update pcie-tegra194 driver with bug fixing and cleanup
> 
> Changes from V1->V2
>    PCI: tegra: Fix handling BME_CHGED event
> 	- Update variable naming
>    PCI: tegra: Fix MSI-X programming
> 	- No change
>    PCI: tegra: Disable interrupts before entering L2
> 	- Rephrase the commit message
>    PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
> 	- Update return value to -ENOTSUPP.
>    PCI: tegra: Cleanup unused code
> 	- No Change
> 
> V1:
> http://patchwork.ozlabs.org/project/linux-pci/patch/20210527115246.20509-2-omp@nvidia.com/
> 
> Om Prakash Singh (5):
>    PCI: tegra: Fix handling BME_CHGED event
>    PCI: tegra: Fix MSI-X programming
>    PCI: tegra: Disable interrupts before entering L2
>    PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
>    PCI: tegra: Cleanup unused code
> 
>   drivers/pci/controller/dwc/pcie-tegra194.c | 36 +++++++++++++---------
>   1 file changed, 22 insertions(+), 14 deletions(-)
>
Bjorn Helgaas June 21, 2021, 6:30 p.m. UTC | #2 
On Sun, Jun 06, 2021 at 01:51:59PM +0530, Om Prakash Singh wrote:
> Update pcie-tegra194 driver with bug fixing and cleanup
> 
> Changes from V1->V2
>   PCI: tegra: Fix handling BME_CHGED event
> 	- Update variable naming
>   PCI: tegra: Fix MSI-X programming
> 	- No change
>   PCI: tegra: Disable interrupts before entering L2
> 	- Rephrase the commit message
>   PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
> 	- Update return value to -ENOTSUPP.
>   PCI: tegra: Cleanup unused code
> 	- No Change
> 
> V1:
> http://patchwork.ozlabs.org/project/linux-pci/patch/20210527115246.20509-2-omp@nvidia.com/
> 
> Om Prakash Singh (5):
>   PCI: tegra: Fix handling BME_CHGED event
>   PCI: tegra: Fix MSI-X programming
>   PCI: tegra: Disable interrupts before entering L2
>   PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode
>   PCI: tegra: Cleanup unused code

Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>

But please update the subject lines to be:

  PCI: tegra194: ...

to differentiate this driver from drivers/pci/controller/pci-tegra.c.
In the past we've used the "PCI: tegra:" prefix for both, but that's
confusing.

I think Lorenzo will take care of this series, but he's been away for
a week or so and will take a bit to catch up.

>  drivers/pci/controller/dwc/pcie-tegra194.c | 36 +++++++++++++---------
>  1 file changed, 22 insertions(+), 14 deletions(-)
> 
> -- 
> 2.17.1
>