| Message ID | f931a26de58e3cc7bb6522fab47e934aca7dc776.1626989327.git.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix direct filesystem access in various test files. | expand |
"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes: > From: Han-Wen Nienhuys <hanwen@google.com> > > In reftable, one cannot take a lock on an individual ref. > > Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> > --- > t/t1410-reflog.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Makes sense, I guess, but it makes it sound as if you can only take a big single lock to freeze everything (as opposed to being able to work on independent refs in parallel). Is that what you meant to say? A file somewhere in .git/refs/ directory shouldn't be a way to lock a ref in the reftable world, either, so it doubly makes sense. > diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh > index 27b9080251a..d42f067ff8c 100755 > --- a/t/t1410-reflog.sh > +++ b/t/t1410-reflog.sh > @@ -374,7 +374,9 @@ test_expect_failure 'reflog with non-commit entries displays all entries' ' > test_line_count = 3 actual > ' > > -test_expect_success 'reflog expire operates on symref not referrent' ' > +# This test takes a lock on an individual ref; this is not supported in > +# reftable. > +test_expect_success REFFILES 'reflog expire operates on symref not referrent' ' > git branch --create-reflog the_symref && > git branch --create-reflog referrent && > git update-ref referrent HEAD &&
diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh index 27b9080251a..d42f067ff8c 100755 --- a/t/t1410-reflog.sh +++ b/t/t1410-reflog.sh @@ -374,7 +374,9 @@ test_expect_failure 'reflog with non-commit entries displays all entries' ' test_line_count = 3 actual ' -test_expect_success 'reflog expire operates on symref not referrent' ' +# This test takes a lock on an individual ref; this is not supported in +# reftable. +test_expect_success REFFILES 'reflog expire operates on symref not referrent' ' git branch --create-reflog the_symref && git branch --create-reflog referrent && git update-ref referrent HEAD &&