diff mbox series

[v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR

Message ID 20210721232616.1935-1-digetx@gmail.com (mailing list archive)
State Queued
Headers show
Series [v2] soc/tegra: Make regulator couplers depend on CONFIG_REGULATOR | expand

Commit Message

Dmitry Osipenko July 21, 2021, 11:26 p.m. UTC
The regulator coupler drivers now use regulator-driver API function that
isn't available during compile-testing. Make regulator coupler drivers
dependent on CONFIG_REGULATOR in Kconfig.

Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---

Changelog:

v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.

 drivers/soc/tegra/Kconfig | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Jon Hunter July 22, 2021, 10:49 a.m. UTC | #1
On 22/07/2021 00:26, Dmitry Osipenko wrote:
> The regulator coupler drivers now use regulator-driver API function that
> isn't available during compile-testing. Make regulator coupler drivers
> dependent on CONFIG_REGULATOR in Kconfig.
> 
> Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> 
> Changelog:
> 
> v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.
> 
>  drivers/soc/tegra/Kconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
> index db49075b1946..1224e1c8c2c9 100644
> --- a/drivers/soc/tegra/Kconfig
> +++ b/drivers/soc/tegra/Kconfig
> @@ -15,7 +15,7 @@ config ARCH_TEGRA_2x_SOC
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  	select SOC_TEGRA_FLOWCTRL
>  	select SOC_TEGRA_PMC
> -	select SOC_TEGRA20_VOLTAGE_COUPLER
> +	select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
>  	select TEGRA_TIMER
>  	help
>  	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
> @@ -29,7 +29,7 @@ config ARCH_TEGRA_3x_SOC
>  	select PL310_ERRATA_769419 if CACHE_L2X0
>  	select SOC_TEGRA_FLOWCTRL
>  	select SOC_TEGRA_PMC
> -	select SOC_TEGRA30_VOLTAGE_COUPLER
> +	select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
>  	select TEGRA_TIMER
>  	help
>  	  Support for NVIDIA Tegra T30 processor family, based on the
> @@ -154,7 +154,9 @@ config SOC_TEGRA_POWERGATE_BPMP
>  config SOC_TEGRA20_VOLTAGE_COUPLER
>  	bool "Voltage scaling support for Tegra20 SoCs"
>  	depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
> +	depends on REGULATOR
>  
>  config SOC_TEGRA30_VOLTAGE_COUPLER
>  	bool "Voltage scaling support for Tegra30 SoCs"
>  	depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
> +	depends on REGULATOR
> 


Acked-by: Jon Hunter <jonathanh@nvidia.com>

Thanks!
Jon
Thierry Reding Aug. 2, 2021, 2:36 p.m. UTC | #2
On Thu, Jul 22, 2021 at 02:26:16AM +0300, Dmitry Osipenko wrote:
> The regulator coupler drivers now use regulator-driver API function that
> isn't available during compile-testing. Make regulator coupler drivers
> dependent on CONFIG_REGULATOR in Kconfig.
> 
> Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> 
> Changelog:
> 
> v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.
> 
>  drivers/soc/tegra/Kconfig | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Seeing that Arnd hasn't picked this up yet, I've now applied it to the
Tegra tree and plan to send out a PR for v5.14 later this week.

Thierry
Arnd Bergmann Aug. 2, 2021, 3:03 p.m. UTC | #3
On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Thu, Jul 22, 2021 at 02:26:16AM +0300, Dmitry Osipenko wrote:
> > The regulator coupler drivers now use regulator-driver API function that
> > isn't available during compile-testing. Make regulator coupler drivers
> > dependent on CONFIG_REGULATOR in Kconfig.
> >
> > Fixes: 03978d42ed0d ("soc/tegra: regulators: Bump voltages on system reboot")
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> > ---
> >
> > Changelog:
> >
> > v2: - No changes. Re-sending to Arnd Bergmann and soc@kernel.org.
> >
> >  drivers/soc/tegra/Kconfig | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Seeing that Arnd hasn't picked this up yet, I've now applied it to the
> Tegra tree and plan to send out a PR for v5.14 later this week.

Sorry about the mixup. In fact I have just picked it up two hours ago.
If you have other fixes that are already in your fixes branch.

       Arnd
Arnd Bergmann Aug. 2, 2021, 3:05 p.m. UTC | #4
On Mon, Aug 2, 2021 at 5:03 PM Arnd Bergmann <arnd@kernel.org> wrote:
> On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <thierry.reding@gmail.com> wrote:
>
> If you have other fixes that are already in your fixes branch
... that you want to have in rc5, please send them soon, as I'm going
to prepare that pull request in a few days.

I'll probably do another one for -rc6 though.

       Arnd
Thierry Reding Aug. 2, 2021, 4:23 p.m. UTC | #5
On Mon, Aug 02, 2021 at 05:05:01PM +0200, Arnd Bergmann wrote:
> On Mon, Aug 2, 2021 at 5:03 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > On Mon, Aug 2, 2021 at 4:35 PM Thierry Reding <thierry.reding@gmail.com> wrote:
> >
> > If you have other fixes that are already in your fixes branch
> ... that you want to have in rc5, please send them soon, as I'm going
> to prepare that pull request in a few days.
> 
> I'll probably do another one for -rc6 though.

Okay, will do. Thanks.

Thierry
diff mbox series

Patch

diff --git a/drivers/soc/tegra/Kconfig b/drivers/soc/tegra/Kconfig
index db49075b1946..1224e1c8c2c9 100644
--- a/drivers/soc/tegra/Kconfig
+++ b/drivers/soc/tegra/Kconfig
@@ -15,7 +15,7 @@  config ARCH_TEGRA_2x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA20_VOLTAGE_COUPLER
+	select SOC_TEGRA20_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra AP20 and T20 processors, based on the
@@ -29,7 +29,7 @@  config ARCH_TEGRA_3x_SOC
 	select PL310_ERRATA_769419 if CACHE_L2X0
 	select SOC_TEGRA_FLOWCTRL
 	select SOC_TEGRA_PMC
-	select SOC_TEGRA30_VOLTAGE_COUPLER
+	select SOC_TEGRA30_VOLTAGE_COUPLER if REGULATOR
 	select TEGRA_TIMER
 	help
 	  Support for NVIDIA Tegra T30 processor family, based on the
@@ -154,7 +154,9 @@  config SOC_TEGRA_POWERGATE_BPMP
 config SOC_TEGRA20_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra20 SoCs"
 	depends on ARCH_TEGRA_2x_SOC || COMPILE_TEST
+	depends on REGULATOR
 
 config SOC_TEGRA30_VOLTAGE_COUPLER
 	bool "Voltage scaling support for Tegra30 SoCs"
 	depends on ARCH_TEGRA_3x_SOC || COMPILE_TEST
+	depends on REGULATOR