| Message ID | 20210803110237.1051032-3-alex.bennee@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | check-tcg hacks for BSD | expand |
On Tue, Aug 3, 2021, 5:02 AM Alex Bennée <alex.bennee@linaro.org> wrote: > This doesn't exist in BSD world and doesn't seem to be needed by > either. > Sys/endian.h is common. FreeBSD has endian.h, but others don't. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > Cc: Warner Losh <imp@bsdimp.com> > Acked by: Warner Losh <imp@bsdimp.com> > --- > tests/tcg/multiarch/sha1.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c > index 87bfbcdf52..0081bd7657 100644 > --- a/tests/tcg/multiarch/sha1.c > +++ b/tests/tcg/multiarch/sha1.c > @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context); > void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t > len); > void SHA1Final(unsigned char digest[20], SHA1_CTX* context); > /* ================ end of sha1.h ================ */ > -#include <endian.h> > > #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - > (bits)))) > > -- > 2.30.2 > >
On Tue, Aug 3, 2021 at 7:55 AM Warner Losh <imp@bsdimp.com> wrote: > > > On Tue, Aug 3, 2021, 5:02 AM Alex Bennée <alex.bennee@linaro.org> wrote: > >> This doesn't exist in BSD world and doesn't seem to be needed by >> either. >> > > Sys/endian.h is common. FreeBSD has endian.h, but others don't. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> >> Cc: Warner Losh <imp@bsdimp.com> >> > > Acked by: Warner Losh <imp@bsdimp.com> > On second thought, this is Reviewed by: Warner Losh <imp@bsdimp.com> since I know the change is good. Warner > --- >> tests/tcg/multiarch/sha1.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c >> index 87bfbcdf52..0081bd7657 100644 >> --- a/tests/tcg/multiarch/sha1.c >> +++ b/tests/tcg/multiarch/sha1.c >> @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context); >> void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t >> len); >> void SHA1Final(unsigned char digest[20], SHA1_CTX* context); >> /* ================ end of sha1.h ================ */ >> -#include <endian.h> >> >> #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - >> (bits)))) >> >> -- >> 2.30.2 >> >>
diff --git a/tests/tcg/multiarch/sha1.c b/tests/tcg/multiarch/sha1.c index 87bfbcdf52..0081bd7657 100644 --- a/tests/tcg/multiarch/sha1.c +++ b/tests/tcg/multiarch/sha1.c @@ -43,7 +43,6 @@ void SHA1Init(SHA1_CTX* context); void SHA1Update(SHA1_CTX* context, const unsigned char* data, uint32_t len); void SHA1Final(unsigned char digest[20], SHA1_CTX* context); /* ================ end of sha1.h ================ */ -#include <endian.h> #define rol(value, bits) (((value) << (bits)) | ((value) >> (32 - (bits))))
This doesn't exist in BSD world and doesn't seem to be needed by either. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Cc: Warner Losh <imp@bsdimp.com> --- tests/tcg/multiarch/sha1.c | 1 - 1 file changed, 1 deletion(-)