mbox series

[v2,0/9] PCI/PM: Improvements related to device transitions into D0

Message ID 11975904.O9o76ZdvQC@kreacher (mailing list archive)
Headers show
Series PCI/PM: Improvements related to device transitions into D0 | expand

Message

Rafael J. Wysocki April 11, 2022, 2:17 p.m. UTC 
Hi All,

On Saturday, April 9, 2022 3:03:14 PM CEST Rafael J. Wysocki wrote:
> Hi All,
> 
> This series supersedes the one at
> 
> https://lore.kernel.org/linux-pm/4198163.ejJDZkT8p0@kreacher
> 
> It addresses some potential issues related to PCI device transitions from
> low-power states into D0 and makes the related code more straightforward
> and so easier to follow.
> 
> Please refer to the patch changelogs for details.

Here's a v2 of this patch series which is being sent, because I realized that
one of the checks in pci_power_up() added by patch [4/7] in v1 was redundant
and can be dropped, but that affected the last 3 patches in the series and
then I noticed that more improvements were possible and hence the new patches
[2/9].

Thanks!

Comments

Mika Westerberg April 12, 2022, 10:08 a.m. UTC | #1 
Hi Rafael,

On Mon, Apr 11, 2022 at 04:17:41PM +0200, Rafael J. Wysocki wrote:
> Hi All,
> 
> On Saturday, April 9, 2022 3:03:14 PM CEST Rafael J. Wysocki wrote:
> > Hi All,
> > 
> > This series supersedes the one at
> > 
> > https://lore.kernel.org/linux-pm/4198163.ejJDZkT8p0@kreacher
> > 
> > It addresses some potential issues related to PCI device transitions from
> > low-power states into D0 and makes the related code more straightforward
> > and so easier to follow.
> > 
> > Please refer to the patch changelogs for details.
> 
> Here's a v2 of this patch series which is being sent, because I realized that
> one of the checks in pci_power_up() added by patch [4/7] in v1 was redundant
> and can be dropped, but that affected the last 3 patches in the series and
> then I noticed that more improvements were possible and hence the new patches
> [2/9].

I sent a few minor nits separately. The series looks good to me in
general and certainly improves readability :)

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Rafael J. Wysocki April 12, 2022, 11:34 a.m. UTC | #2 
Hi Mika,

On Tue, Apr 12, 2022 at 1:24 PM Mika Westerberg
<mika.westerberg@linux.intel.com> wrote:
>
> Hi Rafael,
>
> On Mon, Apr 11, 2022 at 04:17:41PM +0200, Rafael J. Wysocki wrote:
> > Hi All,
> >
> > On Saturday, April 9, 2022 3:03:14 PM CEST Rafael J. Wysocki wrote:
> > > Hi All,
> > >
> > > This series supersedes the one at
> > >
> > > https://lore.kernel.org/linux-pm/4198163.ejJDZkT8p0@kreacher
> > >
> > > It addresses some potential issues related to PCI device transitions from
> > > low-power states into D0 and makes the related code more straightforward
> > > and so easier to follow.
> > >
> > > Please refer to the patch changelogs for details.
> >
> > Here's a v2 of this patch series which is being sent, because I realized that
> > one of the checks in pci_power_up() added by patch [4/7] in v1 was redundant
> > and can be dropped, but that affected the last 3 patches in the series and
> > then I noticed that more improvements were possible and hence the new patches
> > [2/9].
>
> I sent a few minor nits separately. The series looks good to me in
> general and certainly improves readability :)
>
> Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Thank you!

I'll address the issues that you have pointed out and send a v3 of
this series later this week.