| Message ID | 20220815050815.22340-5-samuel@sholland.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: Allwinner D1 platform support | expand |
On 15/08/2022 08:08, Samuel Holland wrote: > Several SoMs and boards are available that feature the Allwinner D1 SoC. > Document their compatible strings. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > .../devicetree/bindings/riscv/sunxi.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/riscv/sunxi.yaml > > diff --git a/Documentation/devicetree/bindings/riscv/sunxi.yaml b/Documentation/devicetree/bindings/riscv/sunxi.yaml > new file mode 100644 > index 000000000000..564a89499894 > --- /dev/null > +++ b/Documentation/devicetree/bindings/riscv/sunxi.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/riscv/sunxi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner RISC-V SoC-based boards > + > +maintainers: > + - Chen-Yu Tsai <wens@csie.org> > + - Jernej Skrabec <jernej.skrabec@gmail.com> > + - Samuel Holland <samuel@sholland.org> > + > +description: > + Allwinner RISC-V SoC-based boards > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: Dongshan Nezha STU SoM > + items: > + - const: 100ask,dongshan-nezha-stu > + - const: allwinner,sun20i-d1 > + > + - description: D1 Nezha board > + items: > + - const: allwinner,d1-nezha You grow the list unnecessary. Several entries should be an enum, unless platform maintainer insists on such approach for all Allwinner Riscv platforms. Just be aware it will grow... Best regards, Krzysztof
Am Dienstag, 16. August 2022, 09:39:38 CEST schrieb Krzysztof Kozlowski: > On 15/08/2022 08:08, Samuel Holland wrote: > > Several SoMs and boards are available that feature the Allwinner D1 SoC. > > Document their compatible strings. > > > > Signed-off-by: Samuel Holland <samuel@sholland.org> > > --- > > > > .../devicetree/bindings/riscv/sunxi.yaml | 64 +++++++++++++++++++ > > 1 file changed, 64 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/riscv/sunxi.yaml > > > > diff --git a/Documentation/devicetree/bindings/riscv/sunxi.yaml b/Documentation/devicetree/bindings/riscv/sunxi.yaml > > new file mode 100644 > > index 000000000000..564a89499894 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/riscv/sunxi.yaml > > @@ -0,0 +1,64 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/riscv/sunxi.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Allwinner RISC-V SoC-based boards > > + > > +maintainers: > > + - Chen-Yu Tsai <wens@csie.org> > > + - Jernej Skrabec <jernej.skrabec@gmail.com> > > + - Samuel Holland <samuel@sholland.org> > > + > > +description: > > + Allwinner RISC-V SoC-based boards > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - description: Dongshan Nezha STU SoM > > + items: > > + - const: 100ask,dongshan-nezha-stu > > + - const: allwinner,sun20i-d1 > > + > > + - description: D1 Nezha board > > + items: > > + - const: allwinner,d1-nezha > > You grow the list unnecessary. Several entries should be an enum, unless > platform maintainer insists on such approach for all Allwinner Riscv > platforms. Just be aware it will grow... Having the binding document provide value to mere mortals and not only the automated tools is plus for me :-) . So obviously personally I like the current style more. But yeah, it's mainly a matter of preference :-) .
Am Montag, 15. August 2022, 07:08:07 CEST schrieb Samuel Holland: > Several SoMs and boards are available that feature the Allwinner D1 SoC. > Document their compatible strings. > > Signed-off-by: Samuel Holland <samuel@sholland.org> Tested-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
On Mon, 15 Aug 2022 00:08:07 -0500, Samuel Holland wrote: > Several SoMs and boards are available that feature the Allwinner D1 SoC. > Document their compatible strings. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > > .../devicetree/bindings/riscv/sunxi.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/riscv/sunxi.yaml > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/riscv/sunxi.yaml b/Documentation/devicetree/bindings/riscv/sunxi.yaml new file mode 100644 index 000000000000..564a89499894 --- /dev/null +++ b/Documentation/devicetree/bindings/riscv/sunxi.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/riscv/sunxi.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner RISC-V SoC-based boards + +maintainers: + - Chen-Yu Tsai <wens@csie.org> + - Jernej Skrabec <jernej.skrabec@gmail.com> + - Samuel Holland <samuel@sholland.org> + +description: + Allwinner RISC-V SoC-based boards + +properties: + $nodename: + const: '/' + compatible: + oneOf: + - description: Dongshan Nezha STU SoM + items: + - const: 100ask,dongshan-nezha-stu + - const: allwinner,sun20i-d1 + + - description: D1 Nezha board + items: + - const: allwinner,d1-nezha + - const: allwinner,sun20i-d1 + + - description: ClockworkPi R-01 SoM and v3.14 board + items: + - const: clockwork,r-01-clockworkpi-v3.14 + - const: allwinner,sun20i-d1 + + - description: ClockworkPi R-01 SoM, v3.14 board, and DevTerm expansion + items: + - const: clockwork,r-01-devterm-v3.14 + - const: clockwork,r-01-clockworkpi-v3.14 + - const: allwinner,sun20i-d1 + + - description: Lichee RV SoM + items: + - const: sipeed,lichee-rv + - const: allwinner,sun20i-d1 + + - description: Carrier boards for the Lichee RV SoM + items: + - enum: + - sipeed,lichee-rv-86-panel-480p + - sipeed,lichee-rv-86-panel-720p + - sipeed,lichee-rv-dock + - const: sipeed,lichee-rv + - const: allwinner,sun20i-d1 + + - description: MangoPi MQ Pro board + items: + - const: widora,mangopi-mq-pro + - const: allwinner,sun20i-d1 + +additionalProperties: true + +...
Several SoMs and boards are available that feature the Allwinner D1 SoC. Document their compatible strings. Signed-off-by: Samuel Holland <samuel@sholland.org> --- .../devicetree/bindings/riscv/sunxi.yaml | 64 +++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/riscv/sunxi.yaml