| Message ID | 20220901222744.2210215-3-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/4] riscv: cleanup svpbmt cpufeature probing | expand |
Reviewed-by: Guo Ren <guoren@kernel.org> On Fri, Sep 2, 2022 at 6:28 AM Heiko Stuebner <heiko@sntech.de> wrote: > > Using the appropriate BIT macro makes the code better readable. > > Suggested-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/riscv/errata/thead/errata.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c > index bffa711aaf64..a6f4bd8ccf3f 100644 > --- a/arch/riscv/errata/thead/errata.c > +++ b/arch/riscv/errata/thead/errata.c > @@ -49,10 +49,10 @@ static u32 thead_errata_probe(unsigned int stage, > u32 cpu_req_errata = 0; > > if (errata_probe_pbmt(stage, archid, impid)) > - cpu_req_errata |= (1U << ERRATA_THEAD_PBMT); > + cpu_req_errata |= BIT(ERRATA_THEAD_PBMT); > > if (errata_probe_cmo(stage, archid, impid)) > - cpu_req_errata |= (1U << ERRATA_THEAD_CMO); > + cpu_req_errata |= BIT(ERRATA_THEAD_CMO); > > return cpu_req_errata; > } > -- > 2.35.1 >
On 01/09/2022 23:27, Heiko Stuebner wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Using the appropriate BIT macro makes the code better readable. As you might imagine, I agree! Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Suggested-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/riscv/errata/thead/errata.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c > index bffa711aaf64..a6f4bd8ccf3f 100644 > --- a/arch/riscv/errata/thead/errata.c > +++ b/arch/riscv/errata/thead/errata.c > @@ -49,10 +49,10 @@ static u32 thead_errata_probe(unsigned int stage, > u32 cpu_req_errata = 0; > > if (errata_probe_pbmt(stage, archid, impid)) > - cpu_req_errata |= (1U << ERRATA_THEAD_PBMT); > + cpu_req_errata |= BIT(ERRATA_THEAD_PBMT); > > if (errata_probe_cmo(stage, archid, impid)) > - cpu_req_errata |= (1U << ERRATA_THEAD_CMO); > + cpu_req_errata |= BIT(ERRATA_THEAD_CMO); > > return cpu_req_errata; > } > -- > 2.35.1 >
On Fri, Sep 02, 2022 at 12:27:43AM +0200, Heiko Stuebner wrote: > Using the appropriate BIT macro makes the code better readable. > > Suggested-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > arch/riscv/errata/thead/errata.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c > index bffa711aaf64..a6f4bd8ccf3f 100644 > --- a/arch/riscv/errata/thead/errata.c > +++ b/arch/riscv/errata/thead/errata.c > @@ -49,10 +49,10 @@ static u32 thead_errata_probe(unsigned int stage, > u32 cpu_req_errata = 0; > > if (errata_probe_pbmt(stage, archid, impid)) > - cpu_req_errata |= (1U << ERRATA_THEAD_PBMT); > + cpu_req_errata |= BIT(ERRATA_THEAD_PBMT); > > if (errata_probe_cmo(stage, archid, impid)) > - cpu_req_errata |= (1U << ERRATA_THEAD_CMO); > + cpu_req_errata |= BIT(ERRATA_THEAD_CMO); > > return cpu_req_errata; > } > -- > 2.35.1 > Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
diff --git a/arch/riscv/errata/thead/errata.c b/arch/riscv/errata/thead/errata.c index bffa711aaf64..a6f4bd8ccf3f 100644 --- a/arch/riscv/errata/thead/errata.c +++ b/arch/riscv/errata/thead/errata.c @@ -49,10 +49,10 @@ static u32 thead_errata_probe(unsigned int stage, u32 cpu_req_errata = 0; if (errata_probe_pbmt(stage, archid, impid)) - cpu_req_errata |= (1U << ERRATA_THEAD_PBMT); + cpu_req_errata |= BIT(ERRATA_THEAD_PBMT); if (errata_probe_cmo(stage, archid, impid)) - cpu_req_errata |= (1U << ERRATA_THEAD_CMO); + cpu_req_errata |= BIT(ERRATA_THEAD_CMO); return cpu_req_errata; }
Using the appropriate BIT macro makes the code better readable. Suggested-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/riscv/errata/thead/errata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)