| Message ID | 4368d585-11ec-d3c7-ec12-7f0afdcedfda@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9e32b4a709f0f7b7adf5d9939c3bd47c78c4f003 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | [1/2] wifi: rtl8xxxu: Fix assignment to bit field priv->pi_enabled | expand |
> -----Original Message----- > From: Bitterblue Smith <rtl8821cerfe2@gmail.com> > Sent: Friday, December 9, 2022 3:32 AM > To: linux-wireless@vger.kernel.org > Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com> > Subject: [PATCH 1/2] wifi: rtl8xxxu: Fix assignment to bit field priv->pi_enabled > > Just because priv->pi_enabled is only one bit doesn't mean it works > like a bool. The value assigned to it loses all bits except bit 0, > so only assign 0 or 1 to it. > > This affects the RTL8188FU, but fixing the assignment didn't make > a difference for my device. The reason is the bit is always 0, I have similar review days ago [1]. [1] https://lore.kernel.org/linux-wireless/cf3d07ff543d4c009dbf51ad7a4d4b21@realtek.com/ > > Fixes: c888183b21f3 ("wifi: rtl8xxxu: Support new chip RTL8188FU") > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com> > --- > drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c > b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c > index 2c4f403ba68f..97e7ff7289fa 100644 > --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c > +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c > @@ -1122,7 +1122,7 @@ static void rtl8188fu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, > > if (t == 0) { > val32 = rtl8xxxu_read32(priv, REG_FPGA0_XA_HSSI_PARM1); > - priv->pi_enabled = val32 & FPGA0_HSSI_PARM1_PI; > + priv->pi_enabled = u32_get_bits(val32, FPGA0_HSSI_PARM1_PI); > } > > /* save RF path */ > -- > 2.38.0 > > ------Please consider the environment before printing this e-mail.
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote: > Just because priv->pi_enabled is only one bit doesn't mean it works > like a bool. The value assigned to it loses all bits except bit 0, > so only assign 0 or 1 to it. > > This affects the RTL8188FU, but fixing the assignment didn't make > a difference for my device. > > Fixes: c888183b21f3 ("wifi: rtl8xxxu: Support new chip RTL8188FU") > Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> > Reviewed-by: Ping-Ke Shih <pkshih@realtek.com> 2 patches applied to wireless-next.git, thanks. 9e32b4a709f0 wifi: rtl8xxxu: Fix assignment to bit field priv->pi_enabled 639c26faf9b1 wifi: rtl8xxxu: Fix assignment to bit field priv->cck_agc_report_type
diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c index 2c4f403ba68f..97e7ff7289fa 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c @@ -1122,7 +1122,7 @@ static void rtl8188fu_phy_iqcalibrate(struct rtl8xxxu_priv *priv, if (t == 0) { val32 = rtl8xxxu_read32(priv, REG_FPGA0_XA_HSSI_PARM1); - priv->pi_enabled = val32 & FPGA0_HSSI_PARM1_PI; + priv->pi_enabled = u32_get_bits(val32, FPGA0_HSSI_PARM1_PI); } /* save RF path */
Just because priv->pi_enabled is only one bit doesn't mean it works like a bool. The value assigned to it loses all bits except bit 0, so only assign 0 or 1 to it. This affects the RTL8188FU, but fixing the assignment didn't make a difference for my device. Fixes: c888183b21f3 ("wifi: rtl8xxxu: Support new chip RTL8188FU") Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com> --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)