diff mbox series

[v3,03/16] aspeed/sdmc: remove redundant macros

Message ID 20240416091904.935283-4-jamin_lin@aspeedtech.com (mailing list archive)
State New, archived
Headers show
Series Add AST2700 support | expand

Commit Message

Jamin Lin April 16, 2024, 9:18 a.m. UTC
These macros are no longer used for ASPEED SOCs, so removes them.

Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
 hw/misc/aspeed_sdmc.c | 15 ---------------
 1 file changed, 15 deletions(-)

Comments

Cédric Le Goater April 16, 2024, 3:30 p.m. UTC | #1
On 4/16/24 11:18, Jamin Lin wrote:
> These macros are no longer used for ASPEED SOCs, so removes them.
> 
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> ---
>   hw/misc/aspeed_sdmc.c | 15 ---------------
>   1 file changed, 15 deletions(-)
> 
> diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
> index 64cd1a81dc..74279bbe8e 100644
> --- a/hw/misc/aspeed_sdmc.c
> +++ b/hw/misc/aspeed_sdmc.c
> @@ -76,10 +76,6 @@
>   #define     ASPEED_SDMC_VGA_32MB            0x2
>   #define     ASPEED_SDMC_VGA_64MB            0x3
>   #define ASPEED_SDMC_DRAM_SIZE(x)        (x & 0x3)
> -#define     ASPEED_SDMC_DRAM_64MB           0x0
> -#define     ASPEED_SDMC_DRAM_128MB          0x1
> -#define     ASPEED_SDMC_DRAM_256MB          0x2
> -#define     ASPEED_SDMC_DRAM_512MB          0x3
>   
>   #define ASPEED_SDMC_READONLY_MASK                       \
>       (ASPEED_SDMC_RESERVED | ASPEED_SDMC_VGA_COMPAT |    \
> @@ -100,17 +96,6 @@
>   #define ASPEED_SDMC_CACHE_ENABLE        (1 << 10) /* differs from AST2400 */
>   #define ASPEED_SDMC_DRAM_TYPE           (1 << 4)  /* differs from AST2400 */
>   
> -/* DRAM size definitions differs */
> -#define     ASPEED_SDMC_AST2500_128MB       0x0
> -#define     ASPEED_SDMC_AST2500_256MB       0x1
> -#define     ASPEED_SDMC_AST2500_512MB       0x2
> -#define     ASPEED_SDMC_AST2500_1024MB      0x3
> -
> -#define     ASPEED_SDMC_AST2600_256MB       0x0
> -#define     ASPEED_SDMC_AST2600_512MB       0x1
> -#define     ASPEED_SDMC_AST2600_1024MB      0x2
> -#define     ASPEED_SDMC_AST2600_2048MB      0x3
> -
>   #define ASPEED_SDMC_AST2500_READONLY_MASK                               \
>       (ASPEED_SDMC_HW_VERSION(0xf) | ASPEED_SDMC_CACHE_INITIAL_DONE |     \
>        ASPEED_SDMC_AST2500_RESERVED | ASPEED_SDMC_VGA_COMPAT |            \
diff mbox series

Patch

diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c
index 64cd1a81dc..74279bbe8e 100644
--- a/hw/misc/aspeed_sdmc.c
+++ b/hw/misc/aspeed_sdmc.c
@@ -76,10 +76,6 @@ 
 #define     ASPEED_SDMC_VGA_32MB            0x2
 #define     ASPEED_SDMC_VGA_64MB            0x3
 #define ASPEED_SDMC_DRAM_SIZE(x)        (x & 0x3)
-#define     ASPEED_SDMC_DRAM_64MB           0x0
-#define     ASPEED_SDMC_DRAM_128MB          0x1
-#define     ASPEED_SDMC_DRAM_256MB          0x2
-#define     ASPEED_SDMC_DRAM_512MB          0x3
 
 #define ASPEED_SDMC_READONLY_MASK                       \
     (ASPEED_SDMC_RESERVED | ASPEED_SDMC_VGA_COMPAT |    \
@@ -100,17 +96,6 @@ 
 #define ASPEED_SDMC_CACHE_ENABLE        (1 << 10) /* differs from AST2400 */
 #define ASPEED_SDMC_DRAM_TYPE           (1 << 4)  /* differs from AST2400 */
 
-/* DRAM size definitions differs */
-#define     ASPEED_SDMC_AST2500_128MB       0x0
-#define     ASPEED_SDMC_AST2500_256MB       0x1
-#define     ASPEED_SDMC_AST2500_512MB       0x2
-#define     ASPEED_SDMC_AST2500_1024MB      0x3
-
-#define     ASPEED_SDMC_AST2600_256MB       0x0
-#define     ASPEED_SDMC_AST2600_512MB       0x1
-#define     ASPEED_SDMC_AST2600_1024MB      0x2
-#define     ASPEED_SDMC_AST2600_2048MB      0x3
-
 #define ASPEED_SDMC_AST2500_READONLY_MASK                               \
     (ASPEED_SDMC_HW_VERSION(0xf) | ASPEED_SDMC_CACHE_INITIAL_DONE |     \
      ASPEED_SDMC_AST2500_RESERVED | ASPEED_SDMC_VGA_COMPAT |            \