| Message ID | 20240430091414.2486196-2-quic_tamizhr@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9f74e7b306dcd7a163822ecb3b1587e9bd3f9c62 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wifi: ath12k: Remove unsupported and unused ring configurations | expand |
On 4/30/2024 2:14 AM, Tamizh Chelvam Raja wrote: > Currently in ath12k_dp_tx_htt_monitor_mode_ring_config() > ath12k_dp_tx_htt_tx_monitor_mode_ring_config() function wrongly called twice. > Fix that by calling ath12k_dp_tx_htt_rx_monitor_mode_ring_config(). > > Currently monitor mode is disabled in driver so the change is compile > tested and boot sequence verified. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> (although very confusing that there is preexisting RX functionality in dp_tx.c)
Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> wrote: > Currently in ath12k_dp_tx_htt_monitor_mode_ring_config() > ath12k_dp_tx_htt_tx_monitor_mode_ring_config() function wrongly called twice. > Fix that by calling ath12k_dp_tx_htt_rx_monitor_mode_ring_config(). > > Currently monitor mode is disabled in driver so the change is compile > tested and boot sequence verified. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> > Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> 3 patches applied to ath-next branch of ath.git, thanks. 9f74e7b306dc wifi: ath12k: fix calling correct function for rx monitor mode ed07ff674509 wifi: ath12k: Remove unsupported tx monitor handling 582e94ebe230 wifi: ath12k: Remove unused tcl_*_ring configuration
diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c index 9b6d7d72f57c..d002de0fd5a1 100644 --- a/drivers/net/wireless/ath/ath12k/dp_tx.c +++ b/drivers/net/wireless/ath/ath12k/dp_tx.c @@ -1050,7 +1050,7 @@ int ath12k_dp_tx_htt_monitor_mode_ring_config(struct ath12k *ar, bool reset) return ret; } - ret = ath12k_dp_tx_htt_tx_monitor_mode_ring_config(ar, reset); + ret = ath12k_dp_tx_htt_rx_monitor_mode_ring_config(ar, reset); if (ret) { ath12k_err(ab, "failed to setup rx monitor filter %d\n", ret); return ret;
Currently in ath12k_dp_tx_htt_monitor_mode_ring_config() ath12k_dp_tx_htt_tx_monitor_mode_ring_config() function wrongly called twice. Fix that by calling ath12k_dp_tx_htt_rx_monitor_mode_ring_config(). Currently monitor mode is disabled in driver so the change is compile tested and boot sequence verified. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Tamizh Chelvam Raja <quic_tamizhr@quicinc.com> --- drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)