| Message ID | 1097d054ed4c67f714679de1253e45a034e647a0.1731425416.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | irqchip: THEAD_C901_ACLINT_SSWI should depend on ARCH_THEAD | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/vmtest-fixes-PR | fail | merge-conflict |
Hi Geert, On 2024-11-12 9:31 AM, Geert Uytterhoeven wrote: > The T-HEAD ACLINT S-mode IPI Interrupt Controller is only present on > T-HEAD SoCs. Hence add a dependency on ARCH_THEAD, to prevent asking This is not correct. This interrupt controller is part of the T-HEAD CPU IP, so it is included in SoCs from other vendors (Allwinner, Sophgo, etc.) that use T-HEAD CPUs as well. Regards, Samuel > the user about this driver when configuring a kernel without T-HEAD SoC > support. > > Fixes: 25caea955cc95050 ("irqchip: Add T-HEAD C900 ACLINT SSWI driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/irqchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 28c19bde55206847..3f4cfcbecc5a4041 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -617,6 +617,7 @@ config THEAD_C900_ACLINT_SSWI > bool "THEAD C9XX ACLINT S-mode IPI Interrupt Controller" > depends on RISCV > depends on SMP > + depends on ARCH_THEAD || COMPILE_TEST > select IRQ_DOMAIN_HIERARCHY > select GENERIC_IRQ_IPI_MUX > help
Hi Samuel, On Tue, Nov 12, 2024 at 5:38 PM Samuel Holland <samuel.holland@sifive.com> wrote: > On 2024-11-12 9:31 AM, Geert Uytterhoeven wrote: > > The T-HEAD ACLINT S-mode IPI Interrupt Controller is only present on > > T-HEAD SoCs. Hence add a dependency on ARCH_THEAD, to prevent asking > > This is not correct. This interrupt controller is part of the T-HEAD CPU IP, so > it is included in SoCs from other vendors (Allwinner, Sophgo, etc.) that use > T-HEAD CPUs as well. In that case I am withdrawing this patch. Thanks for the explanation! Gr{oetje,eeting}s, Geert
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 28c19bde55206847..3f4cfcbecc5a4041 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -617,6 +617,7 @@ config THEAD_C900_ACLINT_SSWI bool "THEAD C9XX ACLINT S-mode IPI Interrupt Controller" depends on RISCV depends on SMP + depends on ARCH_THEAD || COMPILE_TEST select IRQ_DOMAIN_HIERARCHY select GENERIC_IRQ_IPI_MUX help
The T-HEAD ACLINT S-mode IPI Interrupt Controller is only present on T-HEAD SoCs. Hence add a dependency on ARCH_THEAD, to prevent asking the user about this driver when configuring a kernel without T-HEAD SoC support. Fixes: 25caea955cc95050 ("irqchip: Add T-HEAD C900 ACLINT SSWI driver") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+)