[mlx5-next,v2,1/3] net/mlx5: Expose optimal performance scatter entries capability
diff mbox series

Message ID 20191007135933.12483-2-leon@kernel.org
State Accepted
Delegated to: Leon Romanovsky
Headers show
Series
  • Optimize SGL registration
Related show

Commit Message

Leon Romanovsky Oct. 7, 2019, 1:59 p.m. UTC
From: Yamin Friedman <yaminf@mellanox.com>

Expose maximum scatter entries per RDMA READ for optimal performance.

Signed-off-by: Yamin Friedman <yaminf@mellanox.com>
Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
---
 include/linux/mlx5/mlx5_ifc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.20.1

Comments

Bart Van Assche Oct. 7, 2019, 3:02 p.m. UTC | #1
On 10/7/19 6:59 AM, Leon Romanovsky wrote:
> -	u8         reserved_at_c0[0x8];
> +	u8         max_sgl_for_optimized_performance[0x8];

Should the name of this member variable perhaps be changed into 
"max_sgl_for_optimal_performance"?

Thanks,

Bart.
Leon Romanovsky Oct. 7, 2019, 3:54 p.m. UTC | #2
On Mon, Oct 07, 2019 at 08:02:50AM -0700, Bart Van Assche wrote:
> On 10/7/19 6:59 AM, Leon Romanovsky wrote:
> > -	u8         reserved_at_c0[0x8];
> > +	u8         max_sgl_for_optimized_performance[0x8];
>
> Should the name of this member variable perhaps be changed into
> "max_sgl_for_optimal_performance"?

We don't want to force our internal HW/FW names on all uverbs users
and drivers. So, the answer is no, it is used for optimized performance,
but it is not the proper name for uverbs.

Thanks

>
> Thanks,
>
> Bart.
Leon Romanovsky Oct. 8, 2019, 5:55 a.m. UTC | #3
On Mon, Oct 07, 2019 at 04:59:31PM +0300, Leon Romanovsky wrote:
> From: Yamin Friedman <yaminf@mellanox.com>
>
> Expose maximum scatter entries per RDMA READ for optimal performance.
>
> Signed-off-by: Yamin Friedman <yaminf@mellanox.com>
> Reviewed-by: Or Gerlitz <ogerlitz@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
>  include/linux/mlx5/mlx5_ifc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

I'm taking this patch to mlx5-next, since it is not controversial.

Thanks

Patch
diff mbox series

diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index 138c50d5a353..c0bfb1d90dd2 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -1153,7 +1153,7 @@  struct mlx5_ifc_cmd_hca_cap_bits {
 	u8         log_max_srq[0x5];
 	u8         reserved_at_b0[0x10];

-	u8         reserved_at_c0[0x8];
+	u8         max_sgl_for_optimized_performance[0x8];
 	u8         log_max_cq_sz[0x8];
 	u8         reserved_at_d0[0xb];
 	u8         log_max_cq[0x5];