diff mbox series

[XEN,v3,03/23] xen/build: Remove confusing comment on the %.s:%.S rule

Message ID 20200226113355.2532224-4-anthony.perard@citrix.com (mailing list archive)
State Superseded
Headers show
Series xen: Build system improvements | expand

Commit Message

Anthony PERARD Feb. 26, 2020, 11:33 a.m. UTC 
That comment was introduce by 3943db776371 ("[XEN] Can be built
-std=gnu99 (except for .S files).") to explain why CFLAGS was removed
from the command line. The comment is already written where the
-std=gnu flags gets remove from AFLAGS, no need to repeat it.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---

Notes:
    v3:
    - new patch

 xen/Rules.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Wei Liu Feb. 26, 2020, 11:53 a.m. UTC | #1 
On Wed, Feb 26, 2020 at 11:33:35AM +0000, Anthony PERARD wrote:
> That comment was introduce by 3943db776371 ("[XEN] Can be built
> -std=gnu99 (except for .S files).") to explain why CFLAGS was removed
> from the command line. The comment is already written where the
> -std=gnu flags gets remove from AFLAGS, no need to repeat it.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Wei Liu <wl@xen.org>
diff mbox series

Patch

diff --git a/xen/Rules.mk b/xen/Rules.mk
index d22a16d28282..c21203351a9f 100644
--- a/xen/Rules.mk
+++ b/xen/Rules.mk
@@ -230,7 +230,6 @@  $(filter %.init.o,$(obj-y) $(obj-bin-y) $(extra-y)): %.init.o: %.o Makefile
 %.s: %.c Makefile
 	$(CC) $(filter-out -Wa$(comma)%,$(CFLAGS)) -S $< -o $@
 
-# -std=gnu{89,99} gets confused by # as an end-of-line comment marker
 %.s: %.S Makefile
 	$(CPP) $(filter-out -Wa$(comma)%,$(AFLAGS)) $< -o $@