diff mbox series

[18/41] show-branch.c: use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status

Message ID 20220321225523.724509-19-gitter.spiros@gmail.com (mailing list archive)
State New, archived
Headers show
Series use the stdlib EXIT_SUCCESS or EXIT_FAILURE exit status | expand

Commit Message

Elia Pinto March 21, 2022, 10:55 p.m. UTC 
The C standard specifies two constants, EXIT_SUCCESS and  EXIT_FAILURE, that may
be  passed  to exit() to indicate successful or unsuccessful termination,
respectively. The value of status in exit(status) may be EXIT_SUCCESS,
EXIT_FAILURE, or any other value, though only the least significant 8 bits (that
is, status & 0377) shall be available to a waiting parent proces. So exit(-1)
return 255.

Use the C standard EXIT_SUCCESS and EXIT_FAILURE to indicate the program exit
status instead of "0" or "1", respectively. In <stdlib.h> EXIT_FAILURE has the
value "1": use EXIT_FAILURE even if the program uses exit(-1), ie 255, for
consistency.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
---
 builtin/show-branch.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/builtin/show-branch.c b/builtin/show-branch.c
index 330b0553b9..04a99aa7b2 100644
--- a/builtin/show-branch.c
+++ b/builtin/show-branch.c
@@ -820,7 +820,7 @@  int cmd_show_branch(int ac, const char **av, const char *prefix)
 
 	if (!ref_name_cnt) {
 		fprintf(stderr, "No revs to be shown.\n");
-		exit(0);
+		exit(EXIT_SUCCESS);
 	}
 
 	for (num_rev = 0; ref_name[num_rev]; num_rev++) {
@@ -898,7 +898,7 @@  int cmd_show_branch(int ac, const char **av, const char *prefix)
 		}
 	}
 	if (extra < 0)
-		exit(0);
+		exit(EXIT_SUCCESS);
 
 	/* Sort topologically */
 	sort_in_topological_order(&seen, sort_order);