diff mbox series

[10/28] ARM: dts: sun8i: tbs-a711: Fix typo in regulators

Message ID 20190325135300.6440-10-maxime.ripard@bootlin.com (mailing list archive)
State New, archived
Headers show
Series [01/28] dt-bindings: arm: Remove the CPU compatible documentation | expand

Commit Message

Maxime Ripard March 25, 2019, 1:52 p.m. UTC 
The regulator properties suffix is -supply, yet a _supply slipped in.

This was working because the regulator framework will provide a dummy
regulator when none is provided in the device tree, and the regulator
itself was always enabled.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chen-Yu Tsai March 25, 2019, 4:59 p.m. UTC | #1 
On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>
> The regulator properties suffix is -supply, yet a _supply slipped in.
>
> This was working because the regulator framework will provide a dummy
> regulator when none is provided in the device tree, and the regulator
> itself was always enabled.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Could you add a fixes tag?

Once added,

Acked-by: Chen-Yu Tsai <wens@csie.org>
Maxime Ripard March 25, 2019, 7:50 p.m. UTC | #2 
On Tue, Mar 26, 2019 at 12:59:01AM +0800, Chen-Yu Tsai wrote:
> On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
> > The regulator properties suffix is -supply, yet a _supply slipped in.
> >
> > This was working because the regulator framework will provide a dummy
> > regulator when none is provided in the device tree, and the regulator
> > itself was always enabled.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Could you add a fixes tag?
>
> Once added,
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>

I added it, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
index 4bda2f9372cb..1e840ab5a541 100644
--- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
+++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts
@@ -417,7 +417,7 @@ 
 &usbphy {
 	usb0_id_det-gpios = <&pio 7 11 GPIO_ACTIVE_HIGH>; /* PH11 */
 	usb0_vbus-supply = <&reg_drivevbus>;
-	usb1_vbus_supply = <&reg_vmain>;
-	usb2_vbus_supply = <&reg_vmain>;
+	usb1_vbus-supply = <&reg_vmain>;
+	usb2_vbus-supply = <&reg_vmain>;
 	status = "okay";
 };