| Message ID | 20190325135300.6440-26-maxime.ripard@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/28] dt-bindings: arm: Remove the CPU compatible documentation | expand |
On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > The SPDIF binding mandates that we have two DMA channels, one for reception > and one in transmission. However, the device tree only specifies one. > > This has gone un-noticed since the driver only has support for transmission > currently. > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> Same comment as the H5. ChenYu
On Tue, Mar 26, 2019 at 10:54 AM Chen-Yu Tsai <wens@csie.org> wrote: > > On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > The SPDIF binding mandates that we have two DMA channels, one for reception > > and one in transmission. However, the device tree only specifies one. > > > > This has gone un-noticed since the driver only has support for transmission > > currently. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> > > Same comment as the H5. Ugh, I meant the H3. > ChenYu
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index 9514dc170970..ec7f27f617fd 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -719,8 +719,8 @@ clocks = <&ccu CLK_BUS_SPDIF>, <&ccu CLK_SPDIF>; resets = <&ccu RST_BUS_SPDIF>; clock-names = "apb", "spdif"; - dmas = <&dma 2>; - dma-names = "tx"; + dmas = <&dma 2>, <&dma 2>; + dma-names = "rx", "tx"; pinctrl-names = "default"; pinctrl-0 = <&spdif_tx_pin>; status = "disabled";
The SPDIF binding mandates that we have two DMA channels, one for reception and one in transmission. However, the device tree only specifies one. This has gone un-noticed since the driver only has support for transmission currently. Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)