diff mbox series

[14/28] arm64: dts: allwinner: a64: Fix endpoints nodes

Message ID 20190325135300.6440-14-maxime.ripard@bootlin.com (mailing list archive)
State New, archived
Headers show
Series [01/28] dt-bindings: arm: Remove the CPU compatible documentation | expand

Commit Message

Maxime Ripard March 25, 2019, 1:52 p.m. UTC
Commit a7f7047ffcee ("arm64: dts: allwinner: a64: Add cross links for the
mixers") introduced a few errors while fixing the cross links. Make sure to
correct them.

Fixes: a7f7047ffcee ("arm64: dts: allwinner: a64: Add cross links for the mixers")
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Chen-Yu Tsai March 25, 2019, 5:02 p.m. UTC | #1
On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
>

You might want to be a bit more specific in the topic, as in "display pipeline
endpoints".

One might confuse it with endpoints of the camera sensor.

> Commit a7f7047ffcee ("arm64: dts: allwinner: a64: Add cross links for the
> mixers") introduced a few errors while fixing the cross links. Make sure to
> correct them.
>
> Fixes: a7f7047ffcee ("arm64: dts: allwinner: a64: Add cross links for the mixers")
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

Otherwise,

Acked-by: Chen-Yu Tsai <wens@csie.org>
Maxime Ripard March 25, 2019, 7:57 p.m. UTC | #2
On Tue, Mar 26, 2019 at 01:02:09AM +0800, Chen-Yu Tsai wrote:
> On Mon, Mar 25, 2019 at 9:53 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote:
> >
>
> You might want to be a bit more specific in the topic, as in "display pipeline
> endpoints".
>
> One might confuse it with endpoints of the camera sensor.
>
> > Commit a7f7047ffcee ("arm64: dts: allwinner: a64: Add cross links for the
> > mixers") introduced a few errors while fixing the cross links. Make sure to
> > correct them.
> >
> > Fixes: a7f7047ffcee ("arm64: dts: allwinner: a64: Add cross links for the mixers")
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
>
> Otherwise,
>
> Acked-by: Chen-Yu Tsai <wens@csie.org>

I fixed it and applied, thanks!
Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
index 6b0b1a55a005..4b79d34da63d 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
@@ -282,6 +282,8 @@ 
 					#size-cells = <0>;
 
 					mixer1_out: port@1 {
+						#address-cells = <1>;
+						#size-cells = <0>;
 						reg = <1>;
 
 						mixer1_out_tcon0: endpoint@0 {
@@ -372,7 +374,7 @@ 
 
 					tcon0_in_mixer1: endpoint@1 {
 						reg = <1>;
-						remote-endpoint = <&mixer1_out_tcon1>;
+						remote-endpoint = <&mixer1_out_tcon0>;
 					};
 				};