| Message ID | 20140212191053.5459.95323.stgit@bhelgaas-glaptop.roam.corp.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Wednesday, February 12, 2014 12:10:53 PM Bjorn Helgaas wrote: > list_for_each_entry() handles empty lists just fine, so there's no need to > check whether the list is empty first. > > No functional change. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > CC: Rafael J. Wysocki <rjw@rjwysocki.net> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/pci/pci.c | 40 +++++++++++++++++++--------------------- > 1 file changed, 19 insertions(+), 21 deletions(-) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 1febe90831b4..52e10e1181d0 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -1611,29 +1611,27 @@ static void pci_pme_list_scan(struct work_struct *work) > struct pci_pme_device *pme_dev, *n; > > mutex_lock(&pci_pme_list_mutex); > - if (!list_empty(&pci_pme_list)) { > - list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) { > - if (pme_dev->dev->pme_poll) { > - struct pci_dev *bridge; > - > - bridge = pme_dev->dev->bus->self; > - /* > - * If bridge is in low power state, the > - * configuration space of subordinate devices > - * may be not accessible > - */ > - if (bridge && bridge->current_state != PCI_D0) > - continue; > - pci_pme_wakeup(pme_dev->dev, NULL); > - } else { > - list_del(&pme_dev->list); > - kfree(pme_dev); > - } > + list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) { > + if (pme_dev->dev->pme_poll) { > + struct pci_dev *bridge; > + > + bridge = pme_dev->dev->bus->self; > + /* > + * If bridge is in low power state, the > + * configuration space of subordinate devices > + * may be not accessible > + */ > + if (bridge && bridge->current_state != PCI_D0) > + continue; > + pci_pme_wakeup(pme_dev->dev, NULL); > + } else { > + list_del(&pme_dev->list); > + kfree(pme_dev); > } > - if (!list_empty(&pci_pme_list)) > - schedule_delayed_work(&pci_pme_work, > - msecs_to_jiffies(PME_TIMEOUT)); > } > + if (!list_empty(&pci_pme_list)) > + schedule_delayed_work(&pci_pme_work, > + msecs_to_jiffies(PME_TIMEOUT)); > mutex_unlock(&pci_pme_list_mutex); > } > >
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 1febe90831b4..52e10e1181d0 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1611,29 +1611,27 @@ static void pci_pme_list_scan(struct work_struct *work) struct pci_pme_device *pme_dev, *n; mutex_lock(&pci_pme_list_mutex); - if (!list_empty(&pci_pme_list)) { - list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) { - if (pme_dev->dev->pme_poll) { - struct pci_dev *bridge; - - bridge = pme_dev->dev->bus->self; - /* - * If bridge is in low power state, the - * configuration space of subordinate devices - * may be not accessible - */ - if (bridge && bridge->current_state != PCI_D0) - continue; - pci_pme_wakeup(pme_dev->dev, NULL); - } else { - list_del(&pme_dev->list); - kfree(pme_dev); - } + list_for_each_entry_safe(pme_dev, n, &pci_pme_list, list) { + if (pme_dev->dev->pme_poll) { + struct pci_dev *bridge; + + bridge = pme_dev->dev->bus->self; + /* + * If bridge is in low power state, the + * configuration space of subordinate devices + * may be not accessible + */ + if (bridge && bridge->current_state != PCI_D0) + continue; + pci_pme_wakeup(pme_dev->dev, NULL); + } else { + list_del(&pme_dev->list); + kfree(pme_dev); } - if (!list_empty(&pci_pme_list)) - schedule_delayed_work(&pci_pme_work, - msecs_to_jiffies(PME_TIMEOUT)); } + if (!list_empty(&pci_pme_list)) + schedule_delayed_work(&pci_pme_work, + msecs_to_jiffies(PME_TIMEOUT)); mutex_unlock(&pci_pme_list_mutex); }
list_for_each_entry() handles empty lists just fine, so there's no need to check whether the list is empty first. No functional change. Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> CC: Rafael J. Wysocki <rjw@rjwysocki.net> --- drivers/pci/pci.c | 40 +++++++++++++++++++--------------------- 1 file changed, 19 insertions(+), 21 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html