| Message ID | 20221111122014.063153448@linutronix.de (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | genirq, PCI/MSI: Support for per device MSI and PCI/IMS - Part 1 cleanups | expand |
On Fri, Nov 11, 2022 at 02:54:27PM +0100, Thomas Gleixner wrote: > To prepare for removing the exposure of __msi_domain_free_irqs() provide a > post_free() callback in the MSI domain ops which can be used to solve > the problem of the only user of __msi_domain_free_irqs() in arch/powerpc. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > include/linux/msi.h | 4 ++++ > kernel/irq/msi.c | 2 ++ > 2 files changed, 6 insertions(+) Make sense, but I do wonder why PPC needs this ordering.. Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Jason
On Wed, Nov 16 2022 at 13:44, Jason Gunthorpe wrote: > On Fri, Nov 11, 2022 at 02:54:27PM +0100, Thomas Gleixner wrote: >> To prepare for removing the exposure of __msi_domain_free_irqs() provide a >> post_free() callback in the MSI domain ops which can be used to solve >> the problem of the only user of __msi_domain_free_irqs() in arch/powerpc. >> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> >> --- >> include/linux/msi.h | 4 ++++ >> kernel/irq/msi.c | 2 ++ >> 2 files changed, 6 insertions(+) > > Make sense, but I do wonder why PPC needs this ordering.. Some hypervisor thing.
--- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -315,6 +315,8 @@ struct msi_domain_info; * function. * @domain_free_irqs: Optional function to override the default free * function. + * @msi_post_free: Optional function which is invoked after freeing + * all interrupts. * * @get_hwirq, @msi_init and @msi_free are callbacks used by the underlying * irqdomain. @@ -359,6 +361,8 @@ struct msi_domain_ops { struct device *dev, int nvec); void (*domain_free_irqs)(struct irq_domain *domain, struct device *dev); + void (*msi_post_free)(struct irq_domain *domain, + struct device *dev); }; /** --- a/kernel/irq/msi.c +++ b/kernel/irq/msi.c @@ -1026,6 +1026,8 @@ void msi_domain_free_irqs_descs_locked(s lockdep_assert_held(&dev->msi.data->mutex); ops->domain_free_irqs(domain, dev); + if (ops->msi_post_free) + ops->msi_post_free(domain, dev); msi_domain_free_msi_descs(info, dev); }
To prepare for removing the exposure of __msi_domain_free_irqs() provide a post_free() callback in the MSI domain ops which can be used to solve the problem of the only user of __msi_domain_free_irqs() in arch/powerpc. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- include/linux/msi.h | 4 ++++ kernel/irq/msi.c | 2 ++ 2 files changed, 6 insertions(+)