| Message ID | 20240512082858.1806694-4-quic_devipriy@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | Add PCIe support for IPQ9574 | expand |
On 12/05/2024 10:28, devi priya wrote: > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pcie-ipq9574 > + then: > + properties: > + clocks: > + minItems: 6 > + maxItems: 6 > + clock-names: > + items: > + - const: ahb # AHB clock > + - const: aux # Auxiliary clock > + - const: axi_m # AXI Master clock > + - const: axi_s # AXI Slave clock > + - const: axi_bridge # AXI bridge clock > + - const: rchng That's introducing one more order of clocks... Please keep it consistent. The only existing case with ahb has it at after axi_m and others. Why making things everytime differently? I also to propose to finally drop the obvious comments, like "AHB clock". It cannot be anything else. AXI Master / slave are descriptive, so should stay. Best regards, Krzysztof
On Mon, May 13, 2024 at 08:48:19AM +0200, Krzysztof Kozlowski wrote: > On 12/05/2024 10:28, devi priya wrote: > > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - qcom,pcie-ipq9574 > > + then: > > + properties: > > + clocks: > > + minItems: 6 > > + maxItems: 6 > > + clock-names: > > + items: > > + - const: ahb # AHB clock > > + - const: aux # Auxiliary clock > > + - const: axi_m # AXI Master clock > > + - const: axi_s # AXI Slave clock > > + - const: axi_bridge # AXI bridge clock > > + - const: rchng > > That's introducing one more order of clocks... Please keep it > consistent. The only existing case with ahb has it at after axi_m and > others. Why making things everytime differently? > > I also to propose to finally drop the obvious comments, like "AHB > clock". It cannot be anything else. AXI Master / slave are descriptive, > so should stay. > +1 to drop the names. - Mani
On 5/13/2024 12:18 PM, Krzysztof Kozlowski wrote: > On 12/05/2024 10:28, devi priya wrote: > >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,pcie-ipq9574 >> + then: >> + properties: >> + clocks: >> + minItems: 6 >> + maxItems: 6 >> + clock-names: >> + items: >> + - const: ahb # AHB clock >> + - const: aux # Auxiliary clock >> + - const: axi_m # AXI Master clock >> + - const: axi_s # AXI Slave clock >> + - const: axi_bridge # AXI bridge clock >> + - const: rchng > > That's introducing one more order of clocks... Please keep it > consistent. The only existing case with ahb has it at after axi_m and > others. Why making things everytime differently? > > I also to propose to finally drop the obvious comments, like "AHB > clock". It cannot be anything else. AXI Master / slave are descriptive, > so should stay. Sure okay, will update this in next spin. Thanks, Devi Priya > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml index cf9a6910b542..65d4c0c0bcd0 100644 --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml @@ -26,6 +26,7 @@ properties: - qcom,pcie-ipq8064-v2 - qcom,pcie-ipq8074 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 - qcom,pcie-msm8996 - qcom,pcie-qcs404 - qcom,pcie-sdm845 @@ -161,6 +162,7 @@ allOf: enum: - qcom,pcie-ipq6018 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 then: properties: reg: @@ -397,6 +399,39 @@ allOf: - const: axi_m_sticky # AXI Master Sticky reset - const: axi_s_sticky # AXI Slave Sticky reset + - if: + properties: + compatible: + contains: + enum: + - qcom,pcie-ipq9574 + then: + properties: + clocks: + minItems: 6 + maxItems: 6 + clock-names: + items: + - const: ahb # AHB clock + - const: aux # Auxiliary clock + - const: axi_m # AXI Master clock + - const: axi_s # AXI Slave clock + - const: axi_bridge # AXI bridge clock + - const: rchng + resets: + minItems: 8 + maxItems: 8 + reset-names: + items: + - const: pipe # PIPE reset + - const: sticky # Core Sticky reset + - const: axi_s_sticky # AXI Slave Sticky reset + - const: axi_s # AXI Slave reset + - const: axi_m_sticky # AXI Master Sticky reset + - const: axi_m # AXI Master reset + - const: aux # AUX Reset + - const: ahb # AHB Reset + - if: properties: compatible: @@ -507,6 +542,7 @@ allOf: - qcom,pcie-ipq8064v2 - qcom,pcie-ipq8074 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 - qcom,pcie-qcs404 then: required: @@ -566,6 +602,7 @@ allOf: - qcom,pcie-ipq8064-v2 - qcom,pcie-ipq8074 - qcom,pcie-ipq8074-gen3 + - qcom,pcie-ipq9574 - qcom,pcie-qcs404 then: properties:
Document the PCIe controller on IPQ9574 platform. Signed-off-by: devi priya <quic_devipriy@quicinc.com> --- Changes in V5: - Dropped msi-parent for pcie node, as it is handled by "msi" IRQ .../devicetree/bindings/pci/qcom,pcie.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+)