| Message ID | 20230922115116.2748804-2-srichara@win-platform-upstream01.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Daniel Lezcano |
| Headers | show |
| Series | Add support for IPQ5018 tsens | expand |
On Fri, 22 Sep 2023 17:21:13 +0530, Sricharan R wrote: > From: Sricharan Ramabadhran <quic_srichara@quicinc.com> > > IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > --- > [v3] Added the tsens-ipq5018 as new binding without rpm > > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On 22/09/2023 13:51, Sricharan R wrote: > From: Sricharan Ramabadhran <quic_srichara@quicinc.com> > > IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. Then why do you allow two interrupts? > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> > --- > [v3] Added the tsens-ipq5018 as new binding without rpm > > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index 27e9e16e6455..a02829deeb24 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -44,6 +44,10 @@ properties: > - qcom,qcs404-tsens > - const: qcom,tsens-v1 > > + - description: v1 of TSENS without rpm > + enum: > + - qcom,ipq5018-tsens You miss now description of interrupts, like the other variants have. Best regards, Krzysztof
On 9/23/2023 5:14 PM, Krzysztof Kozlowski wrote: > On 22/09/2023 13:51, Sricharan R wrote: >> From: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> >> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. > > Then why do you allow two interrupts? > infact there is only one interrupt. Will fix in the binding description. >> >> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com> >> --- >> [v3] Added the tsens-ipq5018 as new binding without rpm >> >> Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> index 27e9e16e6455..a02829deeb24 100644 >> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> @@ -44,6 +44,10 @@ properties: >> - qcom,qcs404-tsens >> - const: qcom,tsens-v1 >> >> + - description: v1 of TSENS without rpm >> + enum: >> + - qcom,ipq5018-tsens > > You miss now description of interrupts, like the other variants have. > ok, will add it. Regards, Sricharan
On 25/09/2023 04:06, Sricharan Ramabadhran wrote: > > > On 9/23/2023 5:14 PM, Krzysztof Kozlowski wrote: >> On 22/09/2023 13:51, Sricharan R wrote: >>> From: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>> >>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >> >> Then why do you allow two interrupts? >> > infact there is only one interrupt. Will fix in the binding > description. Description? So you still allow two interrupts? No, this must be constrained in allOf:if:then. Best regards, Krzysztof
On 9/25/2023 12:16 PM, Krzysztof Kozlowski wrote: > On 25/09/2023 04:06, Sricharan Ramabadhran wrote: >> >> >> On 9/23/2023 5:14 PM, Krzysztof Kozlowski wrote: >>> On 22/09/2023 13:51, Sricharan R wrote: >>>> From: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>>> >>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>> >>> Then why do you allow two interrupts? >>> >> infact there is only one interrupt. Will fix in the binding >> description. > > Description? So you still allow two interrupts? No, this must be > constrained in allOf:if:then. > ok, it should be fine to add this new compatible to the existing allof:if:then block of v1 targets ? (Because they also have same single interrupt (uplow) constraint) Regards, Sricharan
On 25/09/2023 12:31, Sricharan Ramabadhran wrote: > > > On 9/25/2023 12:16 PM, Krzysztof Kozlowski wrote: >> On 25/09/2023 04:06, Sricharan Ramabadhran wrote: >>> >>> >>> On 9/23/2023 5:14 PM, Krzysztof Kozlowski wrote: >>>> On 22/09/2023 13:51, Sricharan R wrote: >>>>> From: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>>>> >>>>> IPQ5018 has tsens v1.0 block with 4 sensors and 1 interrupt. >>>> >>>> Then why do you allow two interrupts? >>>> >>> infact there is only one interrupt. Will fix in the binding >>> description. >> >> Description? So you still allow two interrupts? No, this must be >> constrained in allOf:if:then. >> > > ok, it should be fine to add this new compatible to the existing > allof:if:then block of v1 targets ? (Because they also have same > single interrupt (uplow) constraint) Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml index 27e9e16e6455..a02829deeb24 100644 --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml @@ -44,6 +44,10 @@ properties: - qcom,qcs404-tsens - const: qcom,tsens-v1 + - description: v1 of TSENS without rpm + enum: + - qcom,ipq5018-tsens + - description: v2 of TSENS items: - enum: