diff mbox series

[6/8] rpmsg: qcom: correct kerneldoc

Message ID 20220501103520.111561-6-krzysztof.kozlowski@linaro.org (mailing list archive)
State New
Headers show
Series [1/8] clk: qcom: alpha-pll: correct kerneldoc | expand

Commit Message

Krzysztof Kozlowski May 1, 2022, 10:35 a.m. UTC
Correct kerneldoc warnings like:

  drivers/rpmsg/qcom_glink_ssr.c:45:
    warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() instead

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/rpmsg/qcom_glink_ssr.c | 2 +-
 drivers/rpmsg/qcom_smd.c       | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Stephen Boyd May 19, 2022, 12:11 a.m. UTC | #1
Quoting Krzysztof Kozlowski (2022-05-01 03:35:18)
> Correct kerneldoc warnings like:
> 
>   drivers/rpmsg/qcom_glink_ssr.c:45:
>     warning: expecting prototype for G(). Prototype was for GLINK_SSR_DO_CLEANUP() instead
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

>  drivers/rpmsg/qcom_glink_ssr.c | 2 +-
>  drivers/rpmsg/qcom_smd.c       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
> index dea929c6045d..776d64446879 100644
> --- a/drivers/rpmsg/qcom_glink_ssr.c
> +++ b/drivers/rpmsg/qcom_glink_ssr.c
> @@ -39,7 +39,7 @@ struct cleanup_done_msg {
>         __le32 seq_num;
>  };
>  
> -/**
> +/*
>   * G-Link SSR protocol commands
>   */
>  #define GLINK_SSR_DO_CLEANUP   0
> diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
> index 7c8c29f6c91d..e7e49d972d36 100644
> --- a/drivers/rpmsg/qcom_smd.c
> +++ b/drivers/rpmsg/qcom_smd.c
> @@ -729,7 +729,7 @@ static int qcom_smd_write_fifo(struct qcom_smd_channel *channel,
>  }
>  
>  /**
> - * qcom_smd_send - write data to smd channel
> + * __qcom_smd_send - write data to smd channel
>   * @channel:   channel handle
>   * @data:      buffer of data to write
>   * @len:       number of bytes to write

Not part of this patch but it says "flag to indicate if write has ca
wait" and I wonder what "ca" means.
diff mbox series

Patch

diff --git a/drivers/rpmsg/qcom_glink_ssr.c b/drivers/rpmsg/qcom_glink_ssr.c
index dea929c6045d..776d64446879 100644
--- a/drivers/rpmsg/qcom_glink_ssr.c
+++ b/drivers/rpmsg/qcom_glink_ssr.c
@@ -39,7 +39,7 @@  struct cleanup_done_msg {
 	__le32 seq_num;
 };
 
-/**
+/*
  * G-Link SSR protocol commands
  */
 #define GLINK_SSR_DO_CLEANUP	0
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 7c8c29f6c91d..e7e49d972d36 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -729,7 +729,7 @@  static int qcom_smd_write_fifo(struct qcom_smd_channel *channel,
 }
 
 /**
- * qcom_smd_send - write data to smd channel
+ * __qcom_smd_send - write data to smd channel
  * @channel:	channel handle
  * @data:	buffer of data to write
  * @len:	number of bytes to write