[RFC,0/1] Adding jh7100 SoC to defconfig

Message

Akira Tsukamoto June 23, 2021, 12:45 p.m. UTC

Would like to have comments for adding jh7100 SoC to defconfig.

To make the upstream friendly, try to add as minimum as possible in
arch/riscv/configs/defconfig required for beaglev-beta against the
upstream defconfig. I might have added too much configs.

Then the distro vendors could use:
make defconfig beablev-fedora.config
or
make defconfig beablev-debian.config

while distro vendors keeping beablev-fedora.config and
beablev-debian.config in their own repositories to make one binary kernel
which boots for all riscv boards.

Probably, it is not good practice to add a different defconfig file under
arch/riscv/configs/ when each new riscv board comes out.

Akira Tsukamoto (1):
  config: Enable jh7100 SoC

 arch/riscv/configs/defconfig | 105 +++++++++++++++++++++++++++++++++++
 1 file changed, 105 insertions(+)

Comments

Drew Fustini June 23, 2021, 6:50 p.m. UTC | #1

On Wed, Jun 23, 2021 at 09:45:52PM +0900, Akira Tsukamoto wrote:
> 
> Would like to have comments for adding jh7100 SoC to defconfig.

Thanks for preparing this defconfig.

Let's refer to the SoC as StarFive JH7100 SoC [1] which is used in the
BeagleV Starlight JH7100 board [2].

> To make the upstream friendly, try to add as minimum as possible in
> arch/riscv/configs/defconfig required for beaglev-beta against the

Please use "BeagleV Starlight JH7100" instead of beaglev-beta.

> upstream defconfig. I might have added too much configs.
> 
> Then the distro vendors could use:
> make defconfig beablev-fedora.config
> or
> make defconfig beablev-debian.config
> 
> while distro vendors keeping beablev-fedora.config and
> beablev-debian.config in their own repositories to make one binary kernel
> which boots for all riscv boards.

Note about naming, BeagleV refers to any RISC-V board produced by
BeagleBoard.org and likely in the future will include other SoC
families.

> 
> Probably, it is not good practice to add a different defconfig file under
> arch/riscv/configs/ when each new riscv board comes out.

We currently have:

  defconfig
  nommu_k210_defconfig
  nommu_k210_sdcard_defconfig
  nommu_virt_defconfig
  rv32_defconfig

It seems like 'defconfig' supports the SiFive Unleashed board which
makes sense as it was the only board for a longtime:

  $ git grep -i sifive
  defconfig:CONFIG_SOC_SIFIVE=y
  defconfig:CONFIG_SPI_SIFIVE=y
  defconfig:CONFIG_GPIO_SIFIVE=y

I suppose the kconfig options needed for BeagleV Starlight JH7100 could
be added to 'defconfig' as long as there were no incompatibilities.  I
assume the k210 versions were added because that is a rather odd SoC
that has a non-supported MMU and thus runs in m-mode.

Thanks,
Drew

[1] https://github.com/starfive-tech/beaglev_doc/
[2] https://github.com/beagleboard/beaglev-starlight

Akira Tsukamoto June 24, 2021, 2:42 p.m. UTC | #2

On 6/24/2021 3:50 AM, Drew Fustini wrote:
> On Wed, Jun 23, 2021 at 09:45:52PM +0900, Akira Tsukamoto wrote:
>>
>> Would like to have comments for adding jh7100 SoC to defconfig.
> 
> Thanks for preparing this defconfig.
> 
> Let's refer to the SoC as StarFive JH7100 SoC [1] which is used in the
> BeagleV Starlight JH7100 board [2].
> 
>> To make the upstream friendly, try to add as minimum as possible in
>> arch/riscv/configs/defconfig required for beaglev-beta against the
> 
> Please use "BeagleV Starlight JH7100" instead of beaglev-beta.
> 
>> upstream defconfig. I might have added too much configs.
>>
>> Then the distro vendors could use:
>> make defconfig beablev-fedora.config
>> or
>> make defconfig beablev-debian.config
>>
>> while distro vendors keeping beablev-fedora.config and
>> beablev-debian.config in their own repositories to make one binary kernel
>> which boots for all riscv boards.
> 
> Note about naming, BeagleV refers to any RISC-V board produced by
> BeagleBoard.org and likely in the future will include other SoC
> families.

No problem, I will rename them all to "StarFive JH7100 SoC" and
"BeagleV Starlight JH7100 board". 

> 
>>
>> Probably, it is not good practice to add a different defconfig file under
>> arch/riscv/configs/ when each new riscv board comes out.
> 
> We currently have:
> 
>   defconfig
>   nommu_k210_defconfig
>   nommu_k210_sdcard_defconfig
>   nommu_virt_defconfig
>   rv32_defconfig
> 
> It seems like 'defconfig' supports the SiFive Unleashed board which
> makes sense as it was the only board for a longtime:
> 
>   $ git grep -i sifive
>   defconfig:CONFIG_SOC_SIFIVE=y
>   defconfig:CONFIG_SPI_SIFIVE=y
>   defconfig:CONFIG_GPIO_SIFIVE=y
> 
> I suppose the kconfig options needed for BeagleV Starlight JH7100 could
> be added to 'defconfig' as long as there were no incompatibilities.  I
> assume the k210 versions were added because that is a rather odd SoC
> that has a non-supported MMU and thus runs in m-mode.

By adding configs for BeagleV Starlight JH7100 booting fine on the current
defconfig which were SiFive Unleashed. Would like to have comments from
the users of Unleashed when this patch starts to settle down.

Akira

> 
> Thanks,
> Drew
> 
> [1] https://github.com/starfive-tech/beaglev_doc/
> [2] https://github.com/beagleboard/beaglev-starlight
>