[v3,4/8] RISC-V: Allow hartid-to-cpuid function to fail.

Commit Message

Atish Patra Feb. 8, 2019, 1:51 a.m. UTC

It is perfectly okay to call riscv_hartid_to_cpuid for a
hartid that is not mapped with an CPU id. It can happen
if the calling functions retrieves the hartid from DT.
However, that hartid was never brought online by the
firmware or kernel for any reasons.

No need to BUG() in the above case. A negative error return
is sufficient and the calling function should check for the
return value always.

Signed-off-by: Atish Patra <[e-mail]>
Reviewed-by: Anup Patel <[e-mail]>
Reviewed-by: Christoph Hellwig <[e-mail]>
---
 arch/riscv/kernel/smp.c | 1 -
 1 file changed, 1 deletion(-)

Patch

diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
index b69883c6..ca99f0fb 100644
--- a/arch/riscv/kernel/smp.c
+++ b/arch/riscv/kernel/smp.c
@@ -60,7 +60,6 @@  int riscv_hartid_to_cpuid(int hartid)
 			return i;
 
 	pr_err("Couldn't find cpu id for hartid [%d]\n", hartid);
-	BUG();
 	return i;
 }