| Message ID | 20230514165651.2199-4-jszhang@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | riscv: add Bouffalolab bl808 support | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Series has a cover letter |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD ac9a78681b92 |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 6 and now 6 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 8 this patch: 8 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | fail | Errors and warnings before: 3 this patch: 5 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | warning | WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Mon, May 15, 2023 at 12:56:44AM +0800, Jisheng Zhang wrote:
> +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml#
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/serial/bouffalolab,bl808-uart.yaml#
Please test the bindings before submission - even dtbs_check catches
that one!
Otherwise, looks fine.
Thanks,
Conor.
On Sun, May 14, 2023 at 07:17:27PM +0100, Conor Dooley wrote: > On Mon, May 15, 2023 at 12:56:44AM +0800, Jisheng Zhang wrote: > > > +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml# > > $id: relative path/filename doesn't match actual path or filename > expected: http://devicetree.org/schemas/serial/bouffalolab,bl808-uart.yaml# > > Please test the bindings before submission - even dtbs_check catches > that one! Aha, I knew the reason. I did run dt_binding_check and dtbs_check, but then I read one of comments in v2 which suggests the renaming, that's to say the dtbs_check is done before the renmaing. Sorry for confusion
On Mon, 15 May 2023 00:56:44 +0800, Jisheng Zhang wrote: > Add bindings doc for Bouffalolab UART Driver > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org> > Acked-by: Palmer Dabbelt <palmer@rivosinc.com> > --- > .../serial/bouffalolab,bl808-uart.yaml | 47 +++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/bouffalolab,bl808-uart.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/serial/bouffalolab,bl808-uart.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/serial/bouffalolab,bl808-uart.yaml# See https://patchwork.ozlabs.org/patch/1781053 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Mon, May 15, 2023 at 07:28:10AM +0800, Jisheng Zhang wrote: > On Sun, May 14, 2023 at 07:17:27PM +0100, Conor Dooley wrote: > > On Mon, May 15, 2023 at 12:56:44AM +0800, Jisheng Zhang wrote: > > > > > +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml# > > > > $id: relative path/filename doesn't match actual path or filename > > expected: http://devicetree.org/schemas/serial/bouffalolab,bl808-uart.yaml# > > > > Please test the bindings before submission - even dtbs_check catches > > that one! > > Aha, I knew the reason. I did run dt_binding_check and dtbs_check, > but then I read one of comments in v2 which suggests the renaming, > that's to say the dtbs_check is done before the renmaing. Sorry for > confusion No worries. Serial aisde, rest of the series looks grand to me, perhaps you want to resubmit the serial bits separately & I'll grab the riscv bits once the serial side is sorted out?
diff --git a/Documentation/devicetree/bindings/serial/bouffalolab,bl808-uart.yaml b/Documentation/devicetree/bindings/serial/bouffalolab,bl808-uart.yaml new file mode 100644 index 000000000000..e1c2c8ac88ab --- /dev/null +++ b/Documentation/devicetree/bindings/serial/bouffalolab,bl808-uart.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2022 Jisheng Zhang <jszhang@kernel.org> +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/serial/bouffalolab,uart.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bouffalolab UART Controller + +maintainers: + - Jisheng Zhang <jszhang@kernel.org> + +allOf: + - $ref: serial.yaml# + +properties: + compatible: + const: bouffalolab,bl808-uart + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + maxItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + uart0: serial@30002000 { + compatible = "bouffalolab,bl808-uart"; + reg = <0x30002000 0x1000>; + interrupts = <53 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&xtal>; + }; +...