| Message ID | 20230902022510.818602-1-xiao.w.wang@intel.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | riscv: alternative: remove alternative boundary symbols in vdso | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/cover_letter | success | Single patches do not need cover letters |
| conchuod/tree_selection | success | Guessed tree name to be for-next at HEAD 44c28940e24b |
| conchuod/fixes_present | success | Fixes tag not required for -next series |
| conchuod/maintainers_pattern | success | MAINTAINERS pattern errors before the patch: 2 and now 2 |
| conchuod/verify_signedoff | success | Signed-off-by tag matches author and committer |
| conchuod/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| conchuod/build_rv64_clang_allmodconfig | success | Errors and warnings before: 9 this patch: 9 |
| conchuod/module_param | success | Was 0 now: 0 |
| conchuod/build_rv64_gcc_allmodconfig | success | Errors and warnings before: 9 this patch: 9 |
| conchuod/build_rv32_defconfig | success | Build OK |
| conchuod/dtb_warn_rv64 | success | Errors and warnings before: 39 this patch: 39 |
| conchuod/header_inline | success | No static functions without inline keyword in header files |
| conchuod/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 9 lines checked |
| conchuod/build_rv64_nommu_k210_defconfig | success | Build OK |
| conchuod/verify_fixes | success | No Fixes tag |
| conchuod/build_rv64_nommu_virt_defconfig | success | Build OK |
On Sat, Sep 02, 2023 at 10:25:10AM +0800, Xiao Wang wrote: > Instruction patching for vdso is based on elf header parsing to get the > beginning and ending of .alternative section, the __alt_start and __alt_end > symbols defined in vdso linker script are not used, so this patch removes > them. The same patch has been in mailist since July: https://lore.kernel.org/linux-riscv/20230726173024.3684-2-jszhang@kernel.org/ Thanks > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > --- > arch/riscv/kernel/vdso/vdso.lds.S | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/riscv/kernel/vdso/vdso.lds.S b/arch/riscv/kernel/vdso/vdso.lds.S > index 82ce64900f3d..d43fd7c7dd11 100644 > --- a/arch/riscv/kernel/vdso/vdso.lds.S > +++ b/arch/riscv/kernel/vdso/vdso.lds.S > @@ -42,9 +42,7 @@ SECTIONS > > . = ALIGN(4); > .alternative : { > - __alt_start = .; > *(.alternative) > - __alt_end = .; > } > > .data : { > -- > 2.25.1 >
> -----Original Message----- > From: Jisheng Zhang <jszhang@kernel.org> > Sent: Monday, September 4, 2023 10:35 PM > To: Wang, Xiao W <xiao.w.wang@intel.com> > Cc: paul.walmsley@sifive.com; palmer@dabbelt.com; > aou@eecs.berkeley.edu; linux-riscv@lists.infradead.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH] riscv: alternative: remove alternative boundary symbols > in vdso > > On Sat, Sep 02, 2023 at 10:25:10AM +0800, Xiao Wang wrote: > > Instruction patching for vdso is based on elf header parsing to get the > > beginning and ending of .alternative section, the __alt_start and __alt_end > > symbols defined in vdso linker script are not used, so this patch removes > > them. > > The same patch has been in mailist since July: > > https://lore.kernel.org/linux-riscv/20230726173024.3684-2- > jszhang@kernel.org/ > > Thanks OK, then please go ahead with that patch review and ignore this one. BRs, Xiao > > > > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> > > --- > > arch/riscv/kernel/vdso/vdso.lds.S | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/arch/riscv/kernel/vdso/vdso.lds.S > b/arch/riscv/kernel/vdso/vdso.lds.S > > index 82ce64900f3d..d43fd7c7dd11 100644 > > --- a/arch/riscv/kernel/vdso/vdso.lds.S > > +++ b/arch/riscv/kernel/vdso/vdso.lds.S > > @@ -42,9 +42,7 @@ SECTIONS > > > > . = ALIGN(4); > > .alternative : { > > - __alt_start = .; > > *(.alternative) > > - __alt_end = .; > > } > > > > .data : { > > -- > > 2.25.1 > >
diff --git a/arch/riscv/kernel/vdso/vdso.lds.S b/arch/riscv/kernel/vdso/vdso.lds.S index 82ce64900f3d..d43fd7c7dd11 100644 --- a/arch/riscv/kernel/vdso/vdso.lds.S +++ b/arch/riscv/kernel/vdso/vdso.lds.S @@ -42,9 +42,7 @@ SECTIONS . = ALIGN(4); .alternative : { - __alt_start = .; *(.alternative) - __alt_end = .; } .data : {
Instruction patching for vdso is based on elf header parsing to get the beginning and ending of .alternative section, the __alt_start and __alt_end symbols defined in vdso linker script are not used, so this patch removes them. Signed-off-by: Xiao Wang <xiao.w.wang@intel.com> --- arch/riscv/kernel/vdso/vdso.lds.S | 2 -- 1 file changed, 2 deletions(-)