[v2,03/11] dt-bindings: riscv: add sophgo sg2042 bindings

Commit Message

Chen Wang Sept. 20, 2023, 6:37 a.m. UTC

Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
Milk-V Pioneer board [2].

[1]: https://en.sophgo.com/product/introduce/sg2042.html
[2]: https://milkv.io/pioneer

Acked-by: Chao Wei <[e-mail]>
Acked-by: Xiaoguang Xing <[e-mail]>
Signed-off-by: Chen Wang <[e-mail]>
---
 .../devicetree/bindings/riscv/sophgo.yaml     | 28 +++++++++++++++++++
 MAINTAINERS                                   |  7 +++++
 2 files changed, 35 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml

Comments

Guo Ren Sept. 20, 2023, 7:43 a.m. UTC | #1

On Wed, Sep 20, 2023 at 2:38 PM Chen Wang <[e-mail]> wrote:
>
> Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> Milk-V Pioneer board [2].
>
> [1]: https://en.sophgo.com/product/introduce/sg2042.html
> [2]: https://milkv.io/pioneer
>
> Acked-by: Chao Wei <[e-mail]>
> Acked-by: Xiaoguang Xing <[e-mail]>
> Signed-off-by: Chen Wang <[e-mail]>
> ---
>  .../devicetree/bindings/riscv/sophgo.yaml     | 28 +++++++++++++++++++
>  MAINTAINERS                                   |  7 +++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
>
> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> new file mode 100644
> index 000000000000..82468ae915db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sophgo SoC-based boards
> +
> +maintainers:
> +  - Chao Wei <[e-mail]>
> +  - Xiaoguang Xing <[e-mail]>
> +
> +description:
> +  Sophgo SoC-based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - milkv,pioneer
> +          - const: sophgo,sg2042
> +
> +additionalProperties: true
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90f13281d297..b74d505003e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20063,6 +20063,13 @@ F:     drivers/char/sonypi.c
>  F:     drivers/platform/x86/sony-laptop.c
>  F:     include/linux/sony-laptop.h
>
> +SOPHGO DEVICETREES
> +M:     Xiaoguang Xing <[e-mail]>
> +M:     Chao Wei <[e-mail]>
> +S:     Maintained
> +F:     Documentation/devicetree/bindings/riscv/sophgo.yaml
> +F:     arch/riscv/boot/dts/sophgo/
> +
>  SOUND
>  M:     Jaroslav Kysela <[e-mail]>
>  M:     Takashi Iwai <[e-mail]>
> --
> 2.25.1
>
LGTM

Reviewed-by: Guo Ren <[e-mail]>

Conor Dooley Sept. 20, 2023, 8:28 a.m. UTC | #2

Yo,

On Wed, Sep 20, 2023 at 02:37:51PM +0800, Chen Wang wrote:
> Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> Milk-V Pioneer board [2].
> 
> [1]: https://en.sophgo.com/product/introduce/sg2042.html
> [2]: https://milkv.io/pioneer

Again, link tags please.

> Acked-by: Chao Wei <[e-mail]>
> Acked-by: Xiaoguang Xing <[e-mail]>
> Signed-off-by: Chen Wang <[e-mail]>
> ---
>  .../devicetree/bindings/riscv/sophgo.yaml     | 28 +++++++++++++++++++
>  MAINTAINERS                                   |  7 +++++
>  2 files changed, 35 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
> 
> diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> new file mode 100644
> index 000000000000..82468ae915db
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sophgo SoC-based boards
> +
> +maintainers:
> +  - Chao Wei <[e-mail]>
> +  - Xiaoguang Xing <[e-mail]>
> +
> +description:
> +  Sophgo SoC-based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - milkv,pioneer
> +          - const: sophgo,sg2042
> +
> +additionalProperties: true
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 90f13281d297..b74d505003e2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20063,6 +20063,13 @@ F:	drivers/char/sonypi.c
>  F:	drivers/platform/x86/sony-laptop.c
>  F:	include/linux/sony-laptop.h
>  
> +SOPHGO DEVICETREES
> +M:	Xiaoguang Xing <[e-mail]>
> +M:	Chao Wei <[e-mail]>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/riscv/sophgo.yaml

> +F:	arch/riscv/boot/dts/sophgo/

Firstly, this directory does not exist at the time of this patch, so it
should not be added here, but rather at the time that you create it.

Secondly, are Xiaoguang Xing and Chao Wei going to monitor the lists &
apply patches for these files? If so, you should add a git tree here
that they will apply patches to & add to linux-next. Also, I'd really
like to see some on-list signs of life from these people, otherwise
I'd rather see your name here instead of theirs.

If they don't intend reviewing/testing/applying patches, I can do it as
a last resort but I would rather that someone who specifically cares for
this hardware does it.

Thanks,
Conor.

> +
>  SOUND
>  M:	Jaroslav Kysela <[e-mail]>
>  M:	Takashi Iwai <[e-mail]>
> -- 
> 2.25.1
>

Krzysztof Kozlowski Sept. 20, 2023, 11:55 a.m. UTC | #3

On 20/09/2023 08:37, Chen Wang wrote:
> Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> Milk-V Pioneer board [2].
> 
> [1]: https://en.sophgo.com/product/introduce/sg2042.html
> [2]: https://milkv.io/pioneer

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

汪辰 Sept. 20, 2023, 12:03 p.m. UTC | #4

Sorry, my mistake to forget adding the tag, will add in next revision.


> -----原始邮件-----
&gt; 发件人: "Krzysztof Kozlowski" <[e-mail]>
&gt; 发送时间: 2023-09-20 19:55:30 (星期三)
&gt; 收件人: "Chen Wang" <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail]
&gt; 抄送: "Chen Wang" <[e-mail]>
&gt; 主题: Re: [PATCH v2 03/11] dt-bindings: riscv: add sophgo sg2042 bindings
&gt; 
&gt; On 20/09/2023 08:37, Chen Wang wrote:
&gt; &gt; Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
&gt; &gt; Milk-V Pioneer board [2].
&gt; &gt; 
&gt; &gt; [1]: https://en.sophgo.com/product/introduce/sg2042.html
&gt; &gt; [2]: https://milkv.io/pioneer
&gt; 
&gt; This is a friendly reminder during the review process.
&gt; 
&gt; It looks like you received a tag and forgot to add it.
&gt; 
&gt; If you do not know the process, here is a short explanation:
&gt; Please add Acked-by/Reviewed-by/Tested-by tags when posting new
&gt; versions, under or above your Signed-off-by tag. Tag is "received", when
&gt; provided in a message replied to you on the mailing list. Tools like b4
&gt; can help here. However, there's no need to repost patches *only* to add
&gt; the tags. The upstream maintainer will do that for tags received on the
&gt; version they apply.
&gt; 
&gt; https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
&gt; 
&gt; If a tag was not added on purpose, please state why and what changed.
&gt; 
&gt; Best regards,
&gt; Krzysztof


------------------------------

Best Regards 
 
 汪辰(Wang Chen) 

</[e-mail]></[e-mail]></[e-mail]>

Jisheng Zhang Sept. 21, 2023, 12:48 a.m. UTC | #5

On Wed, Sep 20, 2023 at 08:03:50PM +0800, 汪辰 wrote:
> Sorry, my mistake to forget adding the tag, will add in next revision.

Hi Chen,

Soft remind: In mailist, top post should be avoided.

> 
> 
> > -----原始邮件-----

And it looks like your email client is wrong, I dunno how your reply
looks in other people's email client, but it looks like html or
rich text in mutt.

> &gt; 发件人: "Krzysztof Kozlowski" <[e-mail]>
> &gt; 发送时间: 2023-09-20 19:55:30 (星期三)
> &gt; 收件人: "Chen Wang" <[e-mail]>, [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail], [e-mail]
> &gt; 抄送: "Chen Wang" <[e-mail]>
> &gt; 主题: Re: [PATCH v2 03/11] dt-bindings: riscv: add sophgo sg2042 bindings
> &gt; 
> &gt; On 20/09/2023 08:37, Chen Wang wrote:
> &gt; &gt; Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> &gt; &gt; Milk-V Pioneer board [2].
> &gt; &gt; 
> &gt; &gt; [1]: https://en.sophgo.com/product/introduce/sg2042.html
> &gt; &gt; [2]: https://milkv.io/pioneer
> &gt; 
> &gt; This is a friendly reminder during the review process.
> &gt; 
> &gt; It looks like you received a tag and forgot to add it.
> &gt; 
> &gt; If you do not know the process, here is a short explanation:
> &gt; Please add Acked-by/Reviewed-by/Tested-by tags when posting new
> &gt; versions, under or above your Signed-off-by tag. Tag is "received", when
> &gt; provided in a message replied to you on the mailing list. Tools like b4
> &gt; can help here. However, there's no need to repost patches *only* to add
> &gt; the tags. The upstream maintainer will do that for tags received on the
> &gt; version they apply.
> &gt; 
> &gt; https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
> &gt; 
> &gt; If a tag was not added on purpose, please state why and what changed.
> &gt; 
> &gt; Best regards,
> &gt; Krzysztof
> 
> 
> ------------------------------
> 
> Best Regards 
>  
>  汪辰(Wang Chen) 
> 
> </[e-mail]></[e-mail]></[e-mail]>

Chen Wang Sept. 21, 2023, 10:21 a.m. UTC | #6

Regards,

unicornx

Conor Dooley <[e-mail]> 于2023年9月20日周三 16:29写道：
>
> Yo,
>
> On Wed, Sep 20, 2023 at 02:37:51PM +0800, Chen Wang wrote:
> > Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> > Milk-V Pioneer board [2].
> >
> > [1]: https://en.sophgo.com/product/introduce/sg2042.html
> > [2]: https://milkv.io/pioneer
>
> Again, link tags please.
>
> > Acked-by: Chao Wei <[e-mail]>
> > Acked-by: Xiaoguang Xing <[e-mail]>
> > Signed-off-by: Chen Wang <[e-mail]>
> > ---
> >  .../devicetree/bindings/riscv/sophgo.yaml     | 28 +++++++++++++++++++
> >  MAINTAINERS                                   |  7 +++++
> >  2 files changed, 35 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > new file mode 100644
> > index 000000000000..82468ae915db
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > @@ -0,0 +1,28 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sophgo SoC-based boards
> > +
> > +maintainers:
> > +  - Chao Wei <[e-mail]>
> > +  - Xiaoguang Xing <[e-mail]>
> > +
> > +description:
> > +  Sophgo SoC-based boards
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - milkv,pioneer
> > +          - const: sophgo,sg2042
> > +
> > +additionalProperties: true
> > +
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 90f13281d297..b74d505003e2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20063,6 +20063,13 @@ F:   drivers/char/sonypi.c
> >  F:   drivers/platform/x86/sony-laptop.c
> >  F:   include/linux/sony-laptop.h
> >
> > +SOPHGO DEVICETREES
> > +M:   Xiaoguang Xing <[e-mail]>
> > +M:   Chao Wei <[e-mail]>
> > +S:   Maintained
> > +F:   Documentation/devicetree/bindings/riscv/sophgo.yaml
>
> > +F:   arch/riscv/boot/dts/sophgo/
>
> Firstly, this directory does not exist at the time of this patch, so it
> should not be added here, but rather at the time that you create it.
>
> Secondly, are Xiaoguang Xing and Chao Wei going to monitor the lists &
> apply patches for these files? If so, you should add a git tree here
> that they will apply patches to & add to linux-next. Also, I'd really
> like to see some on-list signs of life from these people, otherwise
> I'd rather see your name here instead of theirs.
>
> If they don't intend reviewing/testing/applying patches, I can do it as
> a last resort but I would rather that someone who specifically cares for
> this hardware does it.
>
> Thanks,
> Conor.
>

Hi, Conor:
Please allow me to explain first. As a community volunteer, I actually
had full discussions and testing with Sophgo people when submitting
patches, so I added tag such "Acked-by: Xiaoguang Xing ..." to the
signature part of most patches. Also if you think a formal email is
required, I will talk them to send it.

As for the issue of MAINTAINERS, I discussed it with the people from
Sophgo. They (including me also) feel that we are not very familiar
with the community process (especially as maintainer, and actually I
modify the file MAINTAINERS is just to suppress warning information
when running checkpatch.pl), so we sincerely hope to invite you, Mr.
Conor, to help us for a period of time on maintenance work, including
checking relevant patches, merging and submitting PRs, we will learn
together with you for a while, and then take over this part of the
work when we become familiar with it. We know that you are also very
busy at work, especially if you don't have the hardware at hand. I
have the hardware here and I can take the responsibility to run
testing. What do you think? I'm waiting for your reply. Thanks in
advance.

> > +
> >  SOUND
> >  M:   Jaroslav Kysela <[e-mail]>
> >  M:   Takashi Iwai <[e-mail]>
> > --
> > 2.25.1
> >

Conor Dooley Sept. 21, 2023, 12:18 p.m. UTC | #7

On Thu, Sep 21, 2023 at 06:21:08PM +0800, Chen Wang wrote:
> Conor Dooley <[e-mail]> 于2023年9月20日周三 16:29写道：
> > On Wed, Sep 20, 2023 at 02:37:51PM +0800, Chen Wang wrote:
> > > Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> > > Milk-V Pioneer board [2].
> > >
> > > [1]: https://en.sophgo.com/product/introduce/sg2042.html
> > > [2]: https://milkv.io/pioneer
> >
> > Again, link tags please.
> >
> > > Acked-by: Chao Wei <[e-mail]>
> > > Acked-by: Xiaoguang Xing <[e-mail]>
> > > Signed-off-by: Chen Wang <[e-mail]>
> > > ---
> > >  .../devicetree/bindings/riscv/sophgo.yaml     | 28 +++++++++++++++++++
> > >  MAINTAINERS                                   |  7 +++++
> > >  2 files changed, 35 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > new file mode 100644
> > > index 000000000000..82468ae915db
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > @@ -0,0 +1,28 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Sophgo SoC-based boards
> > > +
> > > +maintainers:
> > > +  - Chao Wei <[e-mail]>
> > > +  - Xiaoguang Xing <[e-mail]>
> > > +
> > > +description:
> > > +  Sophgo SoC-based boards
> > > +
> > > +properties:
> > > +  $nodename:
> > > +    const: '/'
> > > +  compatible:
> > > +    oneOf:
> > > +      - items:
> > > +          - enum:
> > > +              - milkv,pioneer
> > > +          - const: sophgo,sg2042
> > > +
> > > +additionalProperties: true
> > > +
> > > +...
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 90f13281d297..b74d505003e2 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -20063,6 +20063,13 @@ F:   drivers/char/sonypi.c
> > >  F:   drivers/platform/x86/sony-laptop.c
> > >  F:   include/linux/sony-laptop.h
> > >
> > > +SOPHGO DEVICETREES
> > > +M:   Xiaoguang Xing <[e-mail]>
> > > +M:   Chao Wei <[e-mail]>
> > > +S:   Maintained
> > > +F:   Documentation/devicetree/bindings/riscv/sophgo.yaml
> >
> > > +F:   arch/riscv/boot/dts/sophgo/
> >
> > Firstly, this directory does not exist at the time of this patch, so it
> > should not be added here, but rather at the time that you create it.
> >
> > Secondly, are Xiaoguang Xing and Chao Wei going to monitor the lists &
> > apply patches for these files? If so, you should add a git tree here
> > that they will apply patches to & add to linux-next. Also, I'd really
> > like to see some on-list signs of life from these people, otherwise
> > I'd rather see your name here instead of theirs.
> >
> > If they don't intend reviewing/testing/applying patches, I can do it as
> > a last resort but I would rather that someone who specifically cares for
> > this hardware does it.
> 
> Please allow me to explain first. As a community volunteer, I actually
> had full discussions and testing with Sophgo people when submitting
> patches, so I added tag such "Acked-by: Xiaoguang Xing ..." to the
> signature part of most patches. Also if you think a formal email is
> required, I will talk them to send it.

No, I'm okay with the acks that are on these patches. I just want to
make sure that those who are acking know why they are & am wondering why
your name is not there, seeing as you're the one who has submitted these
patches.

> As for the issue of MAINTAINERS, I discussed it with the people from
> Sophgo. They (including me also) feel that we are not very familiar
> with the community process (especially as maintainer, and actually I
> modify the file MAINTAINERS is just to suppress warning information
> when running checkpatch.pl), so we sincerely hope to invite you, Mr.
> Conor,

Oh god, there's no need to call me "Mr. Conor". Conor will do perfectly
fine!

> to help us for a period of time on maintenance work, including
> checking relevant patches, merging and submitting PRs, we will learn
> together with you for a while, and then take over this part of the
> work when we become familiar with it. We know that you are also very
> busy at work, especially if you don't have the hardware at hand. I
> have the hardware here and I can take the responsibility to run
> testing. What do you think? I'm waiting for your reply. Thanks in
> advance.

That seems fine to me. In that case, you should add yourself to the
MAINTAINERS entry.

Thanks,
Conor.

Chen Wang Sept. 21, 2023, 1:40 p.m. UTC | #8

Regards,

unicornx

Conor Dooley <[e-mail]> 于2023年9月21日周四 20:18写道：
>
> On Thu, Sep 21, 2023 at 06:21:08PM +0800, Chen Wang wrote:
> > Conor Dooley <[e-mail]> 于2023年9月20日周三 16:29写道：
> > > On Wed, Sep 20, 2023 at 02:37:51PM +0800, Chen Wang wrote:
> > > > Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> > > > Milk-V Pioneer board [2].
> > > >
> > > > [1]: https://en.sophgo.com/product/introduce/sg2042.html
> > > > [2]: https://milkv.io/pioneer
> > >
> > > Again, link tags please.
> > >
> > > > Acked-by: Chao Wei <[e-mail]>
> > > > Acked-by: Xiaoguang Xing <[e-mail]>
> > > > Signed-off-by: Chen Wang <[e-mail]>
> > > > ---
> > > >  .../devicetree/bindings/riscv/sophgo.yaml     | 28 +++++++++++++++++++
> > > >  MAINTAINERS                                   |  7 +++++
> > > >  2 files changed, 35 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > > new file mode 100644
> > > > index 000000000000..82468ae915db
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > > @@ -0,0 +1,28 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Sophgo SoC-based boards
> > > > +
> > > > +maintainers:
> > > > +  - Chao Wei <[e-mail]>
> > > > +  - Xiaoguang Xing <[e-mail]>
> > > > +
> > > > +description:
> > > > +  Sophgo SoC-based boards
> > > > +
> > > > +properties:
> > > > +  $nodename:
> > > > +    const: '/'
> > > > +  compatible:
> > > > +    oneOf:
> > > > +      - items:
> > > > +          - enum:
> > > > +              - milkv,pioneer
> > > > +          - const: sophgo,sg2042
> > > > +
> > > > +additionalProperties: true
> > > > +
> > > > +...
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 90f13281d297..b74d505003e2 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -20063,6 +20063,13 @@ F:   drivers/char/sonypi.c
> > > >  F:   drivers/platform/x86/sony-laptop.c
> > > >  F:   include/linux/sony-laptop.h
> > > >
> > > > +SOPHGO DEVICETREES
> > > > +M:   Xiaoguang Xing <[e-mail]>
> > > > +M:   Chao Wei <[e-mail]>
> > > > +S:   Maintained
> > > > +F:   Documentation/devicetree/bindings/riscv/sophgo.yaml
> > >
> > > > +F:   arch/riscv/boot/dts/sophgo/
> > >
> > > Firstly, this directory does not exist at the time of this patch, so it
> > > should not be added here, but rather at the time that you create it.
> > >
> > > Secondly, are Xiaoguang Xing and Chao Wei going to monitor the lists &
> > > apply patches for these files? If so, you should add a git tree here
> > > that they will apply patches to & add to linux-next. Also, I'd really
> > > like to see some on-list signs of life from these people, otherwise
> > > I'd rather see your name here instead of theirs.
> > >
> > > If they don't intend reviewing/testing/applying patches, I can do it as
> > > a last resort but I would rather that someone who specifically cares for
> > > this hardware does it.
> >
> > Please allow me to explain first. As a community volunteer, I actually
> > had full discussions and testing with Sophgo people when submitting
> > patches, so I added tag such "Acked-by: Xiaoguang Xing ..." to the
> > signature part of most patches. Also if you think a formal email is
> > required, I will talk them to send it.
>
> No, I'm okay with the acks that are on these patches. I just want to
> make sure that those who are acking know why they are & am wondering why
> your name is not there, seeing as you're the one who has submitted these
> patches.
>
> > As for the issue of MAINTAINERS, I discussed it with the people from
> > Sophgo. They (including me also) feel that we are not very familiar
> > with the community process (especially as maintainer, and actually I
> > modify the file MAINTAINERS is just to suppress warning information
> > when running checkpatch.pl), so we sincerely hope to invite you, Mr.
> > Conor,
>
> Oh god, there's no need to call me "Mr. Conor". Conor will do perfectly
> fine!
>
> > to help us for a period of time on maintenance work, including
> > checking relevant patches, merging and submitting PRs, we will learn
> > together with you for a while, and then take over this part of the
> > work when we become familiar with it. We know that you are also very
> > busy at work, especially if you don't have the hardware at hand. I
> > have the hardware here and I can take the responsibility to run
> > testing. What do you think? I'm waiting for your reply. Thanks in
> > advance.
>
> That seems fine to me. In that case, you should add yourself to the
> MAINTAINERS entry.
>
> Thanks,
> Conor.

Okay，I will add it in next revision, thank you again.

Chen Wang Sept. 21, 2023, 1:51 p.m. UTC | #9

Regards,

unicornx

Conor Dooley <[e-mail]> 于2023年9月21日周四 20:18写道：
>
> On Thu, Sep 21, 2023 at 06:21:08PM +0800, Chen Wang wrote:
> > Conor Dooley <[e-mail]> 于2023年9月20日周三 16:29写道：
> > > On Wed, Sep 20, 2023 at 02:37:51PM +0800, Chen Wang wrote:
> > > > Add DT binding documentation for the Sophgo SG2042 Soc [1] and the
> > > > Milk-V Pioneer board [2].
> > > >
> > > > [1]: https://en.sophgo.com/product/introduce/sg2042.html
> > > > [2]: https://milkv.io/pioneer
> > >
> > > Again, link tags please.
> > >
> > > > Acked-by: Chao Wei <[e-mail]>
> > > > Acked-by: Xiaoguang Xing <[e-mail]>
> > > > Signed-off-by: Chen Wang <[e-mail]>
> > > > ---
> > > >  .../devicetree/bindings/riscv/sophgo.yaml     | 28 +++++++++++++++++++
> > > >  MAINTAINERS                                   |  7 +++++
> > > >  2 files changed, 35 insertions(+)
> > > >  create mode 100644 Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > > new file mode 100644
> > > > index 000000000000..82468ae915db
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
> > > > @@ -0,0 +1,28 @@
> > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Sophgo SoC-based boards
> > > > +
> > > > +maintainers:
> > > > +  - Chao Wei <[e-mail]>
> > > > +  - Xiaoguang Xing <[e-mail]>
> > > > +
> > > > +description:
> > > > +  Sophgo SoC-based boards
> > > > +
> > > > +properties:
> > > > +  $nodename:
> > > > +    const: '/'
> > > > +  compatible:
> > > > +    oneOf:
> > > > +      - items:
> > > > +          - enum:
> > > > +              - milkv,pioneer
> > > > +          - const: sophgo,sg2042
> > > > +
> > > > +additionalProperties: true
> > > > +
> > > > +...
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 90f13281d297..b74d505003e2 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -20063,6 +20063,13 @@ F:   drivers/char/sonypi.c
> > > >  F:   drivers/platform/x86/sony-laptop.c
> > > >  F:   include/linux/sony-laptop.h
> > > >
> > > > +SOPHGO DEVICETREES
> > > > +M:   Xiaoguang Xing <[e-mail]>
> > > > +M:   Chao Wei <[e-mail]>
> > > > +S:   Maintained
> > > > +F:   Documentation/devicetree/bindings/riscv/sophgo.yaml
> > >
> > > > +F:   arch/riscv/boot/dts/sophgo/
> > >
> > > Firstly, this directory does not exist at the time of this patch, so it
> > > should not be added here, but rather at the time that you create it.
> > >
> > > Secondly, are Xiaoguang Xing and Chao Wei going to monitor the lists &
> > > apply patches for these files? If so, you should add a git tree here
> > > that they will apply patches to & add to linux-next. Also, I'd really
> > > like to see some on-list signs of life from these people, otherwise
> > > I'd rather see your name here instead of theirs.
> > >
> > > If they don't intend reviewing/testing/applying patches, I can do it as
> > > a last resort but I would rather that someone who specifically cares for
> > > this hardware does it.
> >
> > Please allow me to explain first. As a community volunteer, I actually
> > had full discussions and testing with Sophgo people when submitting
> > patches, so I added tag such "Acked-by: Xiaoguang Xing ..." to the
> > signature part of most patches. Also if you think a formal email is
> > required, I will talk them to send it.
>
> No, I'm okay with the acks that are on these patches. I just want to
> make sure that those who are acking know why they are & am wondering why
> your name is not there, seeing as you're the one who has submitted these
> patches.
>
> > As for the issue of MAINTAINERS, I discussed it with the people from
> > Sophgo. They (including me also) feel that we are not very familiar
> > with the community process (especially as maintainer, and actually I
> > modify the file MAINTAINERS is just to suppress warning information
> > when running checkpatch.pl), so we sincerely hope to invite you, Mr.
> > Conor,
>
> Oh god, there's no need to call me "Mr. Conor". Conor will do perfectly
> fine!
>
> > to help us for a period of time on maintenance work, including
> > checking relevant patches, merging and submitting PRs, we will learn
> > together with you for a while, and then take over this part of the
> > work when we become familiar with it. We know that you are also very
> > busy at work, especially if you don't have the hardware at hand. I
> > have the hardware here and I can take the responsibility to run
> > testing. What do you think? I'm waiting for your reply. Thanks in
> > advance.
>
> That seems fine to me. In that case, you should add yourself to the
> MAINTAINERS entry.
>
> Thanks,
> Conor.

Conor, do you want me to add you to the MAINTAINERS entry too?

Conor Dooley Sept. 21, 2023, 2 p.m. UTC | #10

On Thu, Sep 21, 2023 at 09:51:58PM +0800, Chen Wang wrote:

> Conor, do you want me to add you to the MAINTAINERS entry too?

Nope, no need. My existing maintainers entries should cover it.

Thanks,
Conor.

Chen Wang Sept. 22, 2023, 1:48 a.m. UTC | #11

Regards,

unicornx


> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 90f13281d297..b74d505003e2 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -20063,6 +20063,13 @@ F:   drivers/char/sonypi.c
> >  F:   drivers/platform/x86/sony-laptop.c
> >  F:   include/linux/sony-laptop.h
> >
> > +SOPHGO DEVICETREES
> > +M:   Xiaoguang Xing <[e-mail]>
> > +M:   Chao Wei <[e-mail]>
> > +S:   Maintained
> > +F:   Documentation/devicetree/bindings/riscv/sophgo.yaml
>
> > +F:   arch/riscv/boot/dts/sophgo/
>
> Firstly, this directory does not exist at the time of this patch, so it
> should not be added here, but rather at the time that you create it.
>
> Secondly, are Xiaoguang Xing and Chao Wei going to monitor the lists &
> apply patches for these files? If so, you should add a git tree here
> that they will apply patches to & add to linux-next. Also, I'd really

Conor, FYI, regarding "add a git tree here that they will apply
patches to & add to linux-next.", I will not add in this patchset. I
plan to add this when we start to take the maintainece work. Let me
know if any questions.

> like to see some on-list signs of life from these people, otherwise
> I'd rather see your name here instead of theirs.
>
> If they don't intend reviewing/testing/applying patches, I can do it as
> a last resort but I would rather that someone who specifically cares for
> this hardware does it.
>
> Thanks,
> Conor.
>
> > +
> >  SOUND
> >  M:   Jaroslav Kysela <[e-mail]>
> >  M:   Takashi Iwai <[e-mail]>
> > --
> > 2.25.1
> >

Patch

diff --git a/Documentation/devicetree/bindings/riscv/sophgo.yaml b/Documentation/devicetree/bindings/riscv/sophgo.yaml
new file mode 100644
index 000000000000..82468ae915db
--- /dev/null
+++ b/Documentation/devicetree/bindings/riscv/sophgo.yaml
@@ -0,0 +1,28 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/riscv/sophgo.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sophgo SoC-based boards
+
+maintainers:
+  - Chao Wei <[e-mail]>
+  - Xiaoguang Xing <[e-mail]>
+
+description:
+  Sophgo SoC-based boards
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - milkv,pioneer
+          - const: sophgo,sg2042
+
+additionalProperties: true
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 90f13281d297..b74d505003e2 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -20063,6 +20063,13 @@  F:	drivers/char/sonypi.c
 F:	drivers/platform/x86/sony-laptop.c
 F:	include/linux/sony-laptop.h
 
+SOPHGO DEVICETREES
+M:	Xiaoguang Xing <[e-mail]>
+M:	Chao Wei <[e-mail]>
+S:	Maintained
+F:	Documentation/devicetree/bindings/riscv/sophgo.yaml
+F:	arch/riscv/boot/dts/sophgo/
+
 SOUND
 M:	Jaroslav Kysela <[e-mail]>
 M:	Takashi Iwai <[e-mail]>