diff mbox series

[5/7] qla2xxx: Remove a set-but-not-used variable

Message ID 20181018224546.189268-6-bvanassche@acm.org (mailing list archive)
State Accepted
Headers show
Series qla2xxx patches for kernel v4.20 | expand

Commit Message

Bart Van Assche Oct. 18, 2018, 10:45 p.m. UTC 
This patch does not change any functionality.

Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/scsi/qla2xxx/qla_os.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Madhani, Himanshu Oct. 30, 2018, 5:02 a.m. UTC | #1 
> On Oct 18, 2018, at 3:45 PM, Bart Van Assche <bvanassche@acm.org> wrote:
> 
> External Email
> 
> This patch does not change any functionality.
> 
> Cc: Himanshu Madhani <himanshu.madhani@cavium.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index dba672f87cb2..01607d2f2c34 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -1749,7 +1749,7 @@ qla2x00_loop_reset(scsi_qla_host_t *vha)
> static void
> __qla2x00_abort_all_cmds(struct qla_qpair *qp, int res)
> {
> -       int cnt, status;
> +       int cnt;
>        unsigned long flags;
>        srb_t *sp;
>        scsi_qla_host_t *vha = qp->vha;
> @@ -1799,8 +1799,8 @@ __qla2x00_abort_all_cmds(struct qla_qpair *qp, int res)
>                                        if (!sp_get(sp)) {
>                                                spin_unlock_irqrestore
>                                                        (qp->qp_lock_ptr, flags);
> -                                               status = qla2xxx_eh_abort(
> -                                                   GET_CMD_SP(sp));
> +                                               qla2xxx_eh_abort(
> +                                                       GET_CMD_SP(sp));
>                                                spin_lock_irqsave
>                                                        (qp->qp_lock_ptr, flags);
>                                        }
> --
> 2.19.1.568.g152ad8e336-goog
> 

Looks good.

Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>

Thanks,
- Himanshu
diff mbox series

Patch

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index dba672f87cb2..01607d2f2c34 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1749,7 +1749,7 @@  qla2x00_loop_reset(scsi_qla_host_t *vha)
 static void
 __qla2x00_abort_all_cmds(struct qla_qpair *qp, int res)
 {
-	int cnt, status;
+	int cnt;
 	unsigned long flags;
 	srb_t *sp;
 	scsi_qla_host_t *vha = qp->vha;
@@ -1799,8 +1799,8 @@  __qla2x00_abort_all_cmds(struct qla_qpair *qp, int res)
 					if (!sp_get(sp)) {
 						spin_unlock_irqrestore
 							(qp->qp_lock_ptr, flags);
-						status = qla2xxx_eh_abort(
-						    GET_CMD_SP(sp));
+						qla2xxx_eh_abort(
+							GET_CMD_SP(sp));
 						spin_lock_irqsave
 							(qp->qp_lock_ptr, flags);
 					}