| Message ID | 20181018224546.189268-8-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | qla2xxx patches for kernel v4.20 | expand |
> On Oct 18, 2018, at 3:45 PM, Bart Van Assche <bvanassche@acm.org> wrote: > > External Email > > Move a debug statement from qlafx00_error_entry() into its caller. Remove > one unused argument from that function. This patch does not change the > behavior of the qla2xxx driver. > > Cc: Himanshu Madhani <himanshu.madhani@cavium.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > drivers/scsi/qla2xxx/qla_mr.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c > index b8f967e61891..60f964c53c01 100644 > --- a/drivers/scsi/qla2xxx/qla_mr.c > +++ b/drivers/scsi/qla2xxx/qla_mr.c > @@ -2681,12 +2681,10 @@ qlafx00_multistatus_entry(struct scsi_qla_host *vha, > * @vha: SCSI driver HA context > * @rsp: response queue > * @pkt: Entry pointer > - * @estatus: > - * @etype: > */ > static void > qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, > - struct sts_entry_fx00 *pkt, uint8_t estatus, uint8_t etype) > + struct sts_entry_fx00 *pkt) > { > srb_t *sp; > struct qla_hw_data *ha = vha->hw; > @@ -2695,9 +2693,6 @@ qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, > struct req_que *req = NULL; > int res = DID_ERROR << 16; > > - ql_dbg(ql_dbg_async, vha, 0x507f, > - "type of error status in response: 0x%x\n", estatus); > - > req = ha->req_q_map[que]; > > sp = qla2x00_get_sp_from_handle(vha, func, req, pkt); > @@ -2745,9 +2740,11 @@ qlafx00_process_response_queue(struct scsi_qla_host *vha, > > if (pkt->entry_status != 0 && > pkt->entry_type != IOCTL_IOSB_TYPE_FX00) { > + ql_dbg(ql_dbg_async, vha, 0x507f, > + "type of error status in response: 0x%x\n", > + pkt->entry_status); > qlafx00_error_entry(vha, rsp, > - (struct sts_entry_fx00 *)pkt, pkt->entry_status, > - pkt->entry_type); > + (struct sts_entry_fx00 *)pkt); > continue; > } > > -- > 2.19.1.568.g152ad8e336-goog > Looks good. Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com> Thanks, - Himanshu
diff --git a/drivers/scsi/qla2xxx/qla_mr.c b/drivers/scsi/qla2xxx/qla_mr.c index b8f967e61891..60f964c53c01 100644 --- a/drivers/scsi/qla2xxx/qla_mr.c +++ b/drivers/scsi/qla2xxx/qla_mr.c @@ -2681,12 +2681,10 @@ qlafx00_multistatus_entry(struct scsi_qla_host *vha, * @vha: SCSI driver HA context * @rsp: response queue * @pkt: Entry pointer - * @estatus: - * @etype: */ static void qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, - struct sts_entry_fx00 *pkt, uint8_t estatus, uint8_t etype) + struct sts_entry_fx00 *pkt) { srb_t *sp; struct qla_hw_data *ha = vha->hw; @@ -2695,9 +2693,6 @@ qlafx00_error_entry(scsi_qla_host_t *vha, struct rsp_que *rsp, struct req_que *req = NULL; int res = DID_ERROR << 16; - ql_dbg(ql_dbg_async, vha, 0x507f, - "type of error status in response: 0x%x\n", estatus); - req = ha->req_q_map[que]; sp = qla2x00_get_sp_from_handle(vha, func, req, pkt); @@ -2745,9 +2740,11 @@ qlafx00_process_response_queue(struct scsi_qla_host *vha, if (pkt->entry_status != 0 && pkt->entry_type != IOCTL_IOSB_TYPE_FX00) { + ql_dbg(ql_dbg_async, vha, 0x507f, + "type of error status in response: 0x%x\n", + pkt->entry_status); qlafx00_error_entry(vha, rsp, - (struct sts_entry_fx00 *)pkt, pkt->entry_status, - pkt->entry_type); + (struct sts_entry_fx00 *)pkt); continue; }
Move a debug statement from qlafx00_error_entry() into its caller. Remove one unused argument from that function. This patch does not change the behavior of the qla2xxx driver. Cc: Himanshu Madhani <himanshu.madhani@cavium.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/scsi/qla2xxx/qla_mr.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-)