mbox series

[v3,0/2] wireless: remove unneeded variable and return 0

Message ID 1572684922-61805-1-git-send-email-zhongjiang@huawei.com (mailing list archive)
Headers show
Series wireless: remove unneeded variable and return 0 | expand

Message

zhong jiang Nov. 2, 2019, 8:55 a.m. UTC
The issue is detected with help of coccinelle.

v2 -> v3:
    Remove [PATCH 3/3] of series. Because fappend will use the
    local variable.  

v1 -> v2:
    libipw_qos_convert_ac_to_parameters() make it void.

zhong jiang (2):
  ipw2x00: Remove redundant variable "rc"
  iwlegacy: Remove redundant variable "ret"

 drivers/net/wireless/intel/ipw2x00/libipw_rx.c | 4 +---
 drivers/net/wireless/intel/iwlegacy/4965-mac.c | 3 +--
 2 files changed, 2 insertions(+), 5 deletions(-)

Comments

Kalle Valo Nov. 4, 2019, 4:20 p.m. UTC | #1
zhong jiang <zhongjiang@huawei.com> writes:

> The issue is detected with help of coccinelle.
>
> v2 -> v3:
>     Remove [PATCH 3/3] of series. Because fappend will use the
>     local variable.  

You really need to test your patches. If you submit patches without
build testing I'm not going to take such patches.
zhong jiang Nov. 5, 2019, 12:32 p.m. UTC | #2
On 2019/11/5 0:20, Kalle Valo wrote:
> zhong jiang <zhongjiang@huawei.com> writes:
>
>> The issue is detected with help of coccinelle.
>>
>> v2 -> v3:
>>     Remove [PATCH 3/3] of series. Because fappend will use the
>>     local variable.  
> You really need to test your patches. If you submit patches without
> build testing I'm not going to take such patches.
>
I am sorry for that. :-[

Thanks,
zhong jiang