| Message ID | 1572684922-61805-2-git-send-email-zhongjiang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e310813279b7ea0f5401384675de818f852445c6 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wireless: remove unneeded variable and return 0 | expand |
zhong jiang <zhongjiang@huawei.com> wrote: > local variable "rc" is not used. It is safe to remove and > There is only one caller of libipw_qos_convert_ac_to_parameters(). > hence make it void > > Signed-off-by: zhong jiang <zhongjiang@huawei.com> 2 patches applied to wireless-drivers-next.git, thanks. e310813279b7 ipw2x00: Remove redundant variable "rc" ea7ad5f12ca2 iwlegacy: Remove redundant variable "ret"
diff --git a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c index 34cfd81..0cb36d1 100644 --- a/drivers/net/wireless/intel/ipw2x00/libipw_rx.c +++ b/drivers/net/wireless/intel/ipw2x00/libipw_rx.c @@ -999,13 +999,12 @@ static int libipw_read_qos_info_element(struct /* * Write QoS parameters from the ac parameters. */ -static int libipw_qos_convert_ac_to_parameters(struct +static void libipw_qos_convert_ac_to_parameters(struct libipw_qos_parameter_info *param_elm, struct libipw_qos_parameters *qos_param) { - int rc = 0; int i; struct libipw_qos_ac_parameter *ac_params; u32 txop; @@ -1030,7 +1029,6 @@ static int libipw_qos_convert_ac_to_parameters(struct txop = le16_to_cpu(ac_params->tx_op_limit) * 32; qos_param->tx_op_limit[i] = cpu_to_le16(txop); } - return rc; } /*
local variable "rc" is not used. It is safe to remove and There is only one caller of libipw_qos_convert_ac_to_parameters(). hence make it void Signed-off-by: zhong jiang <zhongjiang@huawei.com> --- drivers/net/wireless/intel/ipw2x00/libipw_rx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)