diff mbox

Add a missing break in parse_station_flags

Message ID AM5PR0701MB265751E3A716081292C5224FE4450@AM5PR0701MB2657.eurprd07.prod.outlook.com (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show

Commit Message

Bernd Edlinger July 8, 2018, 9:57 a.m. UTC 
I was looking at usually suppressed gcc warnings,
[-Wimplicit-fallthrough=] in this case:

The code definitely looks like a break is missing here.
However I am not able to test the NL80211_IFTYPE_MESH_POINT,
nor do I actually know what might be :)
So please use this patch with caution and only if you are
able to do some testing.

Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>

---
  net/wireless/nl80211.c | 1 +
  1 file changed, 1 insertion(+)

-- 
1.9.1

Comments

Kalle Valo July 23, 2018, 9:30 a.m. UTC | #1 
Bernd Edlinger <bernd.edlinger@hotmail.de> writes:

> I was looking at usually suppressed gcc warnings,
> [-Wimplicit-fallthrough=] in this case:
>
> The code definitely looks like a break is missing here.
> However I am not able to test the NL80211_IFTYPE_MESH_POINT,
> nor do I actually know what might be :)
> So please use this patch with caution and only if you are
> able to do some testing.
>
> Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
> ---
>   net/wireless/nl80211.c | 1 +
>   1 file changed, 1 insertion(+)

You should use prefix "nl80211: " in the title.

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject
diff mbox

Patch

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 4eece06..6537b5d 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -4409,6 +4409,7 @@  static int parse_station_flags(struct genl_info *info,
  		params->sta_flags_mask = BIT(NL80211_STA_FLAG_AUTHENTICATED) |
  					 BIT(NL80211_STA_FLAG_MFP) |
  					 BIT(NL80211_STA_FLAG_AUTHORIZED);
+		break;
  	default:
  		return -EINVAL;
  	}