| Message ID | 20190310003428.11723-3-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | target/m68k: Optimize few instructions using deposit/extraxt_i32() | expand |
On 3/9/19 4:34 PM, Philippe Mathieu-Daudé wrote: > case OS_BYTE: > - tcg_gen_andi_i32(reg, reg, 0xffffff00); > tmp = tcg_temp_new(); > tcg_gen_ext8u_i32(tmp, val); Might as well elide this as well. > - tcg_gen_or_i32(reg, reg, tmp); > + tcg_gen_deposit_i32(reg, tmp, reg, 8, 24); > tcg_temp_free(tmp); > break; > case OS_WORD: > - tcg_gen_andi_i32(reg, reg, 0xffff0000); > tmp = tcg_temp_new(); > tcg_gen_ext16u_i32(tmp, val); Likewise. > - tcg_gen_or_i32(reg, reg, tmp); > + tcg_gen_deposit_i32(reg, tmp, reg, 16, 16); > tcg_temp_free(tmp); > break;
diff --git a/target/m68k/translate.c b/target/m68k/translate.c index ab801b6ceb..55766fd7ef 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -720,17 +720,15 @@ static void gen_partset_reg(int opsize, TCGv reg, TCGv val) TCGv tmp; switch (opsize) { case OS_BYTE: - tcg_gen_andi_i32(reg, reg, 0xffffff00); tmp = tcg_temp_new(); tcg_gen_ext8u_i32(tmp, val); - tcg_gen_or_i32(reg, reg, tmp); + tcg_gen_deposit_i32(reg, tmp, reg, 8, 24); tcg_temp_free(tmp); break; case OS_WORD: - tcg_gen_andi_i32(reg, reg, 0xffff0000); tmp = tcg_temp_new(); tcg_gen_ext16u_i32(tmp, val); - tcg_gen_or_i32(reg, reg, tmp); + tcg_gen_deposit_i32(reg, tmp, reg, 16, 16); tcg_temp_free(tmp); break; case OS_LONG:
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- target/m68k/translate.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)