[v2,2/4] meson: Warn when TCI is selected but TCG backend is available

Commit Message

Philippe Mathieu-Daudé Jan. 22, 2021, 10:58 a.m. UTC

Some new users get confused with 'TCG' and 'TCI', and enable TCI
support expecting to enable TCG.

Emit a warning when native TCG backend is available on the
host architecture, mentioning this is a suboptimal configuration.

Reviewed-by: Stefan Weil <[e-mail]>
Reviewed-by: Thomas Huth <[e-mail]>
Signed-off-by: Philippe Mathieu-Daudé <[e-mail]>
---
 meson.build | 3 +++
 1 file changed, 3 insertions(+)

Patch

diff --git a/meson.build b/meson.build
index d5b76150e49..d3df5fa3516 100644
--- a/meson.build
+++ b/meson.build
@@ -234,6 +234,9 @@ 
       error('Unsupported CPU @0@, try --enable-tcg-interpreter'.format(cpu))
     endif
   endif
+  if 'CONFIG_TCG_INTERPRETER' in config_host and cpu in supported_cpus
+    warning('Experimental TCI requested while native TCG is available on @0@, suboptimal performance expected'.format(cpu))
+  endif
   accelerators += 'CONFIG_TCG'
   config_host += { 'CONFIG_TCG': 'y' }
 endif