| Message ID | 20210511103502.2875844-1-f4bug@amsat.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Constify bitmask_transtbl fcntl/mmap flags_tlb[] | expand |
On 5/11/21 5:35 AM, Philippe Mathieu-Daudé wrote: > Keep bitmask_transtbl in .rodata by marking the arrays const. > > Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org> > --- > linux-user/syscall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
Le 11/05/2021 à 12:35, Philippe Mathieu-Daudé a écrit : > Keep bitmask_transtbl in .rodata by marking the arrays const. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > linux-user/syscall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 95d79ddc437..64f486743a9 100644 > --- a/linux-user/syscall.c > +++ b/linux-user/syscall.c > @@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags, > _syscall2(int, membarrier, int, cmd, int, flags) > #endif > > -static bitmask_transtbl fcntl_flags_tbl[] = { > +static const bitmask_transtbl fcntl_flags_tbl[] = { > { TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, }, > { TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, }, > { TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, }, > @@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = { > .print = print_termios, > }; > > -static bitmask_transtbl mmap_flags_tbl[] = { > +static const bitmask_transtbl mmap_flags_tbl[] = { > { TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED }, > { TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE }, > { TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED }, > Reviewed-by: Laurent Vivier <laurent@vivier.eu>
On Tue, May 11, 2021 at 6:51 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > > Keep bitmask_transtbl in .rodata by marking the arrays const. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > linux-user/syscall.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 95d79ddc437..64f486743a9 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -365,7 +365,7 @@ _syscall5(int, sys_statx, int, dirfd, const char *, pathname, int, flags, _syscall2(int, membarrier, int, cmd, int, flags) #endif -static bitmask_transtbl fcntl_flags_tbl[] = { +static const bitmask_transtbl fcntl_flags_tbl[] = { { TARGET_O_ACCMODE, TARGET_O_WRONLY, O_ACCMODE, O_WRONLY, }, { TARGET_O_ACCMODE, TARGET_O_RDWR, O_ACCMODE, O_RDWR, }, { TARGET_O_CREAT, TARGET_O_CREAT, O_CREAT, O_CREAT, }, @@ -6062,7 +6062,7 @@ static const StructEntry struct_termios_def = { .print = print_termios, }; -static bitmask_transtbl mmap_flags_tbl[] = { +static const bitmask_transtbl mmap_flags_tbl[] = { { TARGET_MAP_SHARED, TARGET_MAP_SHARED, MAP_SHARED, MAP_SHARED }, { TARGET_MAP_PRIVATE, TARGET_MAP_PRIVATE, MAP_PRIVATE, MAP_PRIVATE }, { TARGET_MAP_FIXED, TARGET_MAP_FIXED, MAP_FIXED, MAP_FIXED },
Keep bitmask_transtbl in .rodata by marking the arrays const. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)